feat(iOS): move all styles in a separate file #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIhnatsiuk
changed the title
szydlovsky
reviewed
Dec 9, 2025
Collaborator
szydlovsky
left a comment
szydlovsky
left a comment
There was a problem hiding this comment.
Only some naming and/or organisation-wise changes we need
Collaborator
There was a problem hiding this comment.
I'd rename it to MakeStyles.h and place it inside of makeStyles folder to have it organized a bit better
| EnrichedTextInputMakeStyles(__kindof EnrichedTextInputView *input); | ||
|
|
||
| FOUNDATION_EXPORT NSDictionary<NSNumber *, NSArray<NSNumber *> *> * | ||
| EnrichedTextInputConflictingStyles(void); |
Collaborator
There was a problem hiding this comment.
Suggested change
| EnrichedTextInputConflictingStyles(void); | |
| EnrichedTextInputMakeConflictingStyles(void); |
| EnrichedTextInputConflictingStyles(void); | ||
|
|
||
| FOUNDATION_EXPORT NSDictionary<NSNumber *, NSArray<NSNumber *> *> * | ||
| EnrichedTextInputBlockingStyles(void); |
Collaborator
There was a problem hiding this comment.
Suggested change
| EnrichedTextInputBlockingStyles(void); | |
| EnrichedTextInputMakeBlockingStyles(void); |
Collaborator
There was a problem hiding this comment.
Same, would rename to MakeStyles.mm and place inside makeStyles folder
| }; | ||
| } | ||
|
|
||
| NSDictionary<NSNumber *, NSArray<NSNumber *> *> *EnrichedTextInputConflictingStyles(void) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| NSDictionary<NSNumber *, NSArray<NSNumber *> *> *EnrichedTextInputConflictingStyles(void) { | |
| NSDictionary<NSNumber *, NSArray<NSNumber *> *> *EnrichedTextInputMakeConflictingStyles(void) { |
| return dict; | ||
| } | ||
|
|
||
| NSDictionary<NSNumber *, NSArray<NSNumber *> *> *EnrichedTextInputBlockingStyles(void) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| NSDictionary<NSNumber *, NSArray<NSNumber *> *> *EnrichedTextInputBlockingStyles(void) { | |
| NSDictionary<NSNumber *, NSArray<NSNumber *> *> *EnrichedTextInputMakeBlockingStyles(void) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The file
EnrichedTextInputView.mmit's huge, and it's really difficult to work with it. So now it handles everything, including styles/props/style application logic, etc. I decided to simplify it by dividing the logic into different classes with the same responsibility. So, the easiest way is to transfer the styles to a separate file.This PR code basically moves all the styles to a separate file to reduce the number of lines and simplify the logic in
EnrichedTextInputView.mmTest Plan
Build an example app for iOS
Screenshots / Videos
Include any visual proof that helps reviewers understand the change — UI updates, bug reproduction or the result of the fix.
Compatibility