refactor: decoder utilizing ffmpeg and ma decoders#1050
Open
Conversation
closetcaiman
approved these changes
May 7, 2026
Contributor
closetcaiman
left a comment
closetcaiman
left a comment
There was a problem hiding this comment.
lgtm,
nice job deduplicating this!
Comment on lines
53
to
59
| bool needsFFmpeg(AudioFormat format) { | ||
| return format == AudioFormat::MP4 || format == AudioFormat::M4A || format == AudioFormat::AAC; | ||
| } | ||
|
|
||
| return result; | ||
| bool needsFFmpegByPath(const std::string &path) { | ||
| return AudioDecoder::pathHasExtension(path, {".mp4", ".m4a", ".aac"}); | ||
| } |
Contributor
There was a problem hiding this comment.
Shouldn't those be included in the header?
Comment on lines
-86
to
-91
|
|
||
| if (initResult != MA_SUCCESS) { | ||
| return Err( | ||
| "Failed to initialize miniaudio decoder: " + | ||
| std::string(ma_result_description(initResult))); | ||
| } |
Contributor
There was a problem hiding this comment.
It would be cool to preserve decoder API errors (from ffmpeg/ma) provided they are informative. Not a must have as it would require to refactor decoding::IncrementalDecoder implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Checklist