refactor: complex functions#1047
Open
closetcaiman wants to merge 28 commits intomainfrom
Open
Conversation
mdydek
requested changes
May 4, 2026
Comment on lines
+179
to
+183
| auto onBufferConsumed = [this, graphManager]( | ||
| size_t bufferId, | ||
| std::shared_ptr<AudioBuffer> buffer, | ||
| bool isLastInQueue, | ||
| bool fireBufferEndedEvent) { |
Collaborator
There was a problem hiding this comment.
use FatFunction here, because it will allocate on audio thread likely
Comment on lines
+150
to
+151
| SingleBufferProcessor processor( | ||
| buffer_.get(), vReadIndex_, loop_, playbackRate, startFrame, endFrame); |
Collaborator
There was a problem hiding this comment.
i think there is no need to create a processor each render quantum, it can wrap some not frequently changed variables, such as buffer and loop
Comment on lines
+46
to
+47
| [[nodiscard]] const AudioBuffer *getBuffer() const override; | ||
| [[nodiscard]] const AudioBuffer *getNextBuffer() const override; |
Collaborator
There was a problem hiding this comment.
let's try to minimize the usage of raw ptrs
Collaborator
There was a problem hiding this comment.
Suggested change
| auto framesNeededToStretch = std::abs(static_cast<int>(playbackRate * static_cast<float>(framesToProcess))); |
has to be like that to allow negative playback rate values
mdydek
requested changes
May 8, 2026
Collaborator
mdydek
left a comment
mdydek
left a comment
There was a problem hiding this comment.
another argument against using #include <something> not #include "something" is that formatter is behaving differently when using "" and it looks very off
|
|
||
| #include <cstddef> | ||
| #include <memory> | ||
| #include "audioapi/core/utils/buffer/SingleBufferProcessor.h" |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include "audioapi/core/utils/buffer/SingleBufferProcessor.h" | |
| #include <audioapi/core/utils/buffer/SingleBufferProcessor.h> |
| const float currentSample = source[state.index]; | ||
| const float nextSample = nextSource[state.nextIndex]; | ||
| destination[writeIndex] = currentSample + state.factor * (nextSample - currentSample); | ||
|
|
| #include <algorithm> | ||
| #include <cstddef> | ||
| #include <memory> | ||
| #include "audioapi/core/utils/buffer/BufferProcessingDirection.h" |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include "audioapi/core/utils/buffer/BufferProcessingDirection.h" | |
| #include <audioapi/core/utils/buffer/BufferProcessingDirection.h> |
| #include <list> | ||
| #include <memory> | ||
| #include <utility> | ||
| #include "audioapi/utils/FatFunction.hpp" |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include "audioapi/utils/FatFunction.hpp" | |
| #include <audioapi/utils/FatFunction.hpp> |
pls be aware of it
Comment on lines
+46
to
+47
| [[nodiscard]] const AudioBuffer *getBuffer() const override; | ||
| [[nodiscard]] const AudioBuffer *getNextBuffer() const override; |
| #include <audioapi/utils/Macros.h> | ||
| #include <cstddef> | ||
| #include <memory> | ||
| #include "audioapi/core/utils/buffer/BufferProcessingDirection.h" |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include "audioapi/core/utils/buffer/BufferProcessingDirection.h" | |
| #include <audioapi/core/utils/buffer/BufferProcessingDirection.h> |
Comment on lines
+39
to
+41
| // queue buffer source | ||
| inline constexpr size_t ON_BUFFER_CONSUMED_CALLBACK_SIZE = 64; | ||
|
|
Collaborator
There was a problem hiding this comment.
I think it can be safely moved to queue buffer source file, for sure it won't be used anywhere else and also is very "local"
| #include <audioapi/core/utils/buffer/BufferProcessorBase.h> | ||
|
|
||
| #include <cstddef> | ||
| #include "audioapi/utils/AudioBuffer.hpp" |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include "audioapi/utils/AudioBuffer.hpp" | |
| #include <audioapi/utils/AudioBuffer.hpp> |
Comment on lines
+155
to
+156
| processor_->setBuffer(buffer_.get()); | ||
| processor_->setLoop(loop_); |
Collaborator
There was a problem hiding this comment.
those values are not changing each render quantum, you can move those calls to appropriate node setters (f.e. update loop in processor only after setLoop is called on node)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Checklist