Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/eslint-plugin/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<div align="center">

# eslint-plugin-typegpu

🚧 **Under Construction** 🚧 -
[GitHub](https://github.com/software-mansion/TypeGPU/tree/main/packages/eslint-plugin)

</div>
7 changes: 7 additions & 0 deletions packages/eslint-plugin/deno.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"exclude": ["."],
"fmt": {
"exclude": ["!."],
"singleQuote": true
}
}
34 changes: 34 additions & 0 deletions packages/eslint-plugin/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"name": "eslint-plugin-typegpu",
"version": "0.9.0",
"description": "An eslint plugin containing custom rules for TypeGPU.",
"type": "module",
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js",
"require": "./dist/index.cjs"
}
},
"scripts": {
"build": "tsup",
"test:types": "pnpm tsc --p ./tsconfig.json --noEmit",
"test": "vitest"
},
"sideEffects": false,
"license": "MIT",
"packageManager": "pnpm@10.15.1",
"dependencies": {
"@typescript-eslint/utils": "^8.53.0"
},
"peerDependencies": {
"eslint": "^9.0.0"
},
"devDependencies": {
"@types/node": "^25.0.10",
"@typescript-eslint/rule-tester": "^8.53.1",
"eslint": "^9.39.2",
"typescript": "^5.9.3",
"vitest": "^4.0.17"
}
}
19 changes: 19 additions & 0 deletions packages/eslint-plugin/src/configs.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import type { TSESLint } from '@typescript-eslint/utils';
import { integerDivision } from './rules/integerDivision.ts';

export const rules = {
'integer-division': integerDivision,
} as const;

type Rules = Record<
`typegpu/${keyof typeof rules}`,
TSESLint.FlatConfig.RuleEntry
>;

export const recommendedRules: Rules = {
'typegpu/integer-division': 'warn',
};

export const allRules: Rules = {
'typegpu/integer-division': 'error',
};
33 changes: 33 additions & 0 deletions packages/eslint-plugin/src/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import pkg from '../package.json';
import type { TSESLint } from '@typescript-eslint/utils';
import { allRules, recommendedRules, rules } from './configs.ts';

const pluginBase: TSESLint.FlatConfig.Plugin = {
meta: {
name: pkg.name,
version: pkg.version,
},
rules,
};

const recommended: TSESLint.FlatConfig.Config = {
name: 'typegpu/recommended',
plugins: { typegpu: pluginBase },
rules: recommendedRules,
};

const all: TSESLint.FlatConfig.Config = {
name: 'typegpu/all',
plugins: { typegpu: pluginBase },
rules: allRules,
};

const plugin: TSESLint.FlatConfig.Plugin = {
...pluginBase,
configs: {
recommended,
all,
},
};

export default plugin;
6 changes: 6 additions & 0 deletions packages/eslint-plugin/src/ruleCreator.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { ESLintUtils } from '@typescript-eslint/utils';

export const createRule = ESLintUtils.RuleCreator(
// TODO: docs for lint rules
() => `https://docs.swmansion.com/TypeGPU/getting-started/`,
);
61 changes: 61 additions & 0 deletions packages/eslint-plugin/src/rules/integerDivision.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
import type { TSESTree } from '@typescript-eslint/utils';
import { createRule } from '../ruleCreator.ts';

// TODO: detect `std.div(d.u32(1), d.u32(2))`
export const integerDivision = createRule({
name: 'integer-division',
meta: {
type: 'suggestion',
docs: { description: `Avoid dividing numbers wrapped in 'u32' and 'i32'.` },
messages: {
intDiv:
"'{{snippet}}' might result in floating point values. To perform integer division, wrap the result in 'd.u32' or 'd.i32' instead.",
},
schema: [],
},
defaultOptions: [],

create(context) {
return {
BinaryExpression(node) {
if (node.operator !== '/') {
return;
}

if (node.parent?.type === 'CallExpression' && isIntCast(node.parent)) {
return;
}

if (isIntCast(node.left) && isIntCast(node.right)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something like 12 / d.u32(5) would be a common pattern (wrapping just the denominator and expecting integer division). I know coding agents tend to do that.

context.report({
node,
messageId: 'intDiv',
data: { snippet: context.sourceCode.getText(node) },
});
}
},
};
},
});

/**
* Checks if a node is a call expression to an integer cast function (i32 or u32).
*
* @example
* // for simplicity, using code snippets instead of ASTs
* isIntCasts('d.u32()'); // true
* isIntCasts('i32()'); // true
* isIntCasts('f32()'); // false
*/
function isIntCast(node: TSESTree.Expression): boolean {
if (node.type !== 'CallExpression') {
return false;
}

let callee: TSESTree.Node = node.callee;
while (callee.type === 'MemberExpression') {
callee = callee.property;
}

return callee.type === 'Identifier' && ['i32', 'u32'].includes(callee.name);
}
46 changes: 46 additions & 0 deletions packages/eslint-plugin/tests/integerDivision.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import { describe } from 'vitest';
import { integerDivision } from '../src/rules/integerDivision.ts';
import { ruleTester } from './ruleTester.ts';

describe('integerDivision', () => {
ruleTester.run('integerDivision', integerDivision, {
valid: [
'1 / 2',
'd.u32(1) / 2',
'1 / d.u32(2)',
'd.u32(d.u32(1) / d.u32(2))',
],
invalid: [
{
code: 'd.u32(1) / d.u32(2)',
errors: [
{ messageId: 'intDiv', data: { snippet: 'd.u32(1) / d.u32(2)' } },
],
},
{
code: 'd.i32(1) / d.i32(2)',
errors: [
{ messageId: 'intDiv', data: { snippet: 'd.i32(1) / d.i32(2)' } },
],
},
{
code: 'd.u32(1) / d.i32(2)',
errors: [
{ messageId: 'intDiv', data: { snippet: 'd.u32(1) / d.i32(2)' } },
],
},
{
code: 'u32(1) / u32(2)',
errors: [
{ messageId: 'intDiv', data: { snippet: 'u32(1) / u32(2)' } },
],
},
{
code: 'd.u32(1) / d.u32(2) / d.u32(3)',
errors: [
{ messageId: 'intDiv', data: { snippet: 'd.u32(1) / d.u32(2)' } },
],
},
],
});
});
10 changes: 10 additions & 0 deletions packages/eslint-plugin/tests/ruleTester.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { RuleTester } from '@typescript-eslint/rule-tester';
import { afterAll, describe, it } from 'vitest';

// RuleTester relies on global hooks for tests.
// Vitest doesn't make the hooks available globally, so we need to bind them.
RuleTester.describe = describe;
RuleTester.it = it;
RuleTester.afterAll = afterAll;

export const ruleTester = new RuleTester();
8 changes: 8 additions & 0 deletions packages/eslint-plugin/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"types": ["node"]
},
"include": ["src/**/*", "tests/**/*"],
"exclude": ["node_modules", "dist"]
}
12 changes: 12 additions & 0 deletions packages/eslint-plugin/tsup.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { defineConfig, type Options } from 'tsup';

const config: Options = {
entry: ['src/index.ts'],
format: ['cjs', 'esm'],
dts: true,
clean: true,
splitting: true,
sourcemap: true,
};

export default defineConfig(config);
8 changes: 8 additions & 0 deletions packages/eslint-plugin/vitest.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { defineConfig } from 'vitest/config';

export default defineConfig({
test: {
include: ['tests/**/*.test.ts'],
environment: 'node',
},
});
2 changes: 1 addition & 1 deletion packages/typegpu/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
},
"homepage": "https://typegpu.com",
"devDependencies": {
"@ark/attest": "^0.53.0",
"@ark/attest": "^0.56.0",
"@typegpu/tgpu-dev-cli": "workspace:*",
"@webgpu/types": "catalog:types",
"arktype": "catalog:",
Expand Down
Loading