fix: Investigate why some examples work differently #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksanderkatan
force-pushed
the
fix/investigate-why-some-examples-work-differently
branch
from
899c0f2 to
5ee25a3
Compare
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (327 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
|
pkg.pr.new packages benchmark commit |
aleksanderkatan
requested review from
cieplypolar,
iwoplaza,
lursz and
reczkok
iwoplaza
approved these changes
Jan 23, 2026
Collaborator
iwoplaza
left a comment
iwoplaza
left a comment
There was a problem hiding this comment.
Awesome! Thanks a lot 💜
Comment on lines
151
to
153
| const mouseRayBuffer = root | ||
| .createBuffer(MouseRay, { | ||
| activated: 0, | ||
| line: Line3({ origin: d.vec3f(), dir: d.vec3f() }), | ||
| }) | ||
| .createBuffer(Line3, Line3({ origin: d.vec3f(), dir: d.vec3f() })) | ||
| .$usage('uniform'); |
Collaborator
There was a problem hiding this comment.
I think we could try and do the following, since the initial value is the default one:
const mouseRayBuffer = root.createBuffer(Line3).$usage('uniform');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mnist Inference - It actually worked just like before, I compared it with an old commit.
Stable Fluids - -||-
3D Fish - The repulsion ray actually was weaker. I made it stronger, and on hover instead of on RMB.
Function Visualizer - I was unable to reproduce the texture size mismatch, I cleaned up unnecessary complications in texture size calculation.