-
-
Notifications
You must be signed in to change notification settings - Fork 48
fix: Improve perlin noise internals and API with accessors #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (331 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
|
pkg.pr.new packages benchmark commit |
| [`${prefix}size`]: { uniform: d.vec2u }, | ||
| [`${prefix}memory`]: { storage: MemorySchema, access: 'readonly' }, | ||
| } as Layout<Prefix>, | ||
| valuesSlot, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a slight breaking change, we can note that in the release notes
422aecc to
e8f1bd9
Compare
e8f1bd9 to
f08b1f6
Compare
Cleanup Self review Update accessor.ts Never too many tests
f08b1f6 to
c1c640d
Compare
reczkok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes
Apart from changing the perlin noise internals and API, there were a few changes to accessors:
AccessorInandMutableAccessorIntypes now live asTgpuAccessor.InandTgpuMutableAccessor.Inrespectively. This can help reduce unnecessary top-level export polution.() => () => () => layout.$.foo). This is helpful when writing a library, and we're unsure whether we can safely access a property in "normal" mode.