-
-
Notifications
You must be signed in to change notification settings - Fork 48
fix: Merge mobile and non-mobile state in our examples page #2058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (323 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
|
pkg.pr.new packages benchmark commit |
| "vcs": { | ||
| "enabled": true, | ||
| "clientKind": "git", | ||
| "useIgnoreFile": true | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this since biome was complaining about my .zed/settings.json file - this makes biome ignore all the files that are ignored by git
8785935 to
cd7e31c
Compare
| <ExampleLayout client:load> | ||
| <ExamplePage client:only="react" /> | ||
| </ExampleLayout> | ||
| <ExampleLayout client:only="react"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to fix hydration
187342b to
a8a45e9
Compare
aleksanderkatan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! 🚗📃
Co-authored-by: Aleksander Katan <56294622+aleksanderkatan@users.noreply.github.com>
Known bug
If the left menu toggle is the first interaction post reload its state is not reflected in the toggle position
Screen.Recording.2026-01-14.at.18.00.37.mov