fix: intermediate representation of array expression #2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
…sion/TypeGPU into fix/arrayExpr-resolve-delay
5 tasks
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (330 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
reczkok
reviewed
Jan 23, 2026
| return snip(value, UnknownData, /* origin */ 'constant'); | ||
| } | ||
|
|
||
| // defers the resolution of array expressions |
Contributor
There was a problem hiding this comment.
Either JSDoc or remove IMO
Comment on lines
+146
to
+151
| constructor( | ||
| public readonly elementType: AnyWgslData, | ||
| public readonly type: AnyWgslData, | ||
| public readonly elements: Snippet[], | ||
| ) { | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| constructor( | |
| public readonly elementType: AnyWgslData, | |
| public readonly type: AnyWgslData, | |
| public readonly elements: Snippet[], | |
| ) { | |
| } | |
| constructor( | |
| public readonly type: WgslArray<AnyWgslData>, | |
| public readonly elements: Snippet[], | |
| ) {} |
| } | ||
|
|
||
| const arrayType = `array<${ | ||
| ctx.resolve(this.elementType).value |
Contributor
There was a problem hiding this comment.
Suggested change
| ctx.resolve(this.elementType).value | |
| ctx.resolve(this.type.elementType).value |
| stitch`${arrayType}(${values})`, | ||
| arrayOf(elemType as wgsl.AnyWgslData, values.length), | ||
| new ArrayExpression( | ||
| elemType as wgsl.AnyWgslData, |
Contributor
There was a problem hiding this comment.
This information is redundant since the arrayType contains it
Suggested change
| elemType as wgsl.AnyWgslData, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
NODE.arrayExprwas encountered in the wgsl generator. Since the resulting snippet's value was a string, we couldn't really access array values.Now:
NODE.arrayExprreturns an intermediate representation (ArrayExpression). Thereby, we delayed its resolution.Additional changes:
NODE.callArrayExpressionNODE.callCloses #2017.