Enhance jsc beautification#4
Open
tjhart wants to merge 2 commits into
Open
Conversation
Author
|
Following up on this PR. I'm open to a more detailed conversation about the intent if you like. @kmagiera , you seem to have written most of it. What are the next steps? |
Author
|
Following up again. I'd rather not create a private fork of this, but I may have to. @kmagiera are there any concerns with the PR? If so I'm happy to work with you to address them. |
|
I'm in a situation where I could use this fix, would it be possible to merge this branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt ad addressing #2 , and also dealing with JSC stack trace entries with a '-1' line number.
I'm open to suggestions.
For example: