-
Notifications
You must be signed in to change notification settings - Fork 386
Fixed PKCS#11 3.2 C_Decapsulate definition #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates to the PKCS#11 header file include a function signature modification for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10–15 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (4)📓 Common learnings📚 Learning: 2025-09-11T16:54:00.370ZApplied to files:
📚 Learning: 2025-08-18T17:59:30.693ZApplied to files:
📚 Learning: 2025-11-11T19:42:46.886ZApplied to files:
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bukka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah looks like this is wrong in p11kit as I just copied it from there. Might be good to also report it to them so next time when we copy new header, we don't have the same issue.
There is a slight difference between reference PKCS#11 3.2 functions header and the one from p11kit merged in #827
Definition of
CK_FLAGS_PTRwas also missingSummary by CodeRabbit
Note: These are API-level changes that may require updates for developers using this library.
✏️ Tip: You can customize this high-level summary in your review settings.