Skip to content

Conversation

@bukka
Copy link
Contributor

@bukka bukka commented Dec 10, 2025

CI was not running on main...

Summary by CodeRabbit

  • Chores
    • Updated CI workflow configuration to streamline branch management and deployment processes.

✏️ Tip: You can customize this high-level summary in your review settings.

@bukka bukka requested a review from a team as a code owner December 10, 2025 11:50
@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The GitHub Actions CI workflow has been updated to trigger exclusively on the main branch, removing all references to the develop and master branches as push triggers.

Changes

Cohort / File(s) Change Summary
CI Workflow Configuration
.github/workflows/ci.yml
Updated branch trigger to target main only; removed develop and master branch triggers

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Area of note: Verify that the removal of develop and master triggers aligns with the repository's branch strategy and that CI is not needed on those branches going forward.

Poem

🐰 A workflow refined, from branches three down to one,
main now leads the race, where all the CI is run,
Simplicity hops in with cleaner triggers bright,
Develop and master take their rest, out of sight!

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ff177d and 2d0f731.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bukka bukka merged commit 8940193 into softhsm:main Dec 10, 2025
8 of 9 checks passed
@bukka
Copy link
Contributor Author

bukka commented Dec 10, 2025

I merged this one quickly as there is nothing to review really :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant