Fix header include error for ck_rsa_pkcs_oaep_params

[ruiliio]

Add missing 'struct' keyword for ck_rsa_pkcs_oaep_params to resolve unknown type name error.

Resolves #810

Summary by CodeRabbit

• Refactor
  • Standardized a public API type for RSA-AES key wrap parameters by switching the OAEP parameters field to an explicit struct type for clarity and consistency. This may require minor source updates for applications interfacing with the API.

[coderabbitai]

Walkthrough

The change updates a member type in struct ck_rsa_aes_key_wrap_params within src/lib/pkcs11/pkcs11.h from a typedef name to an explicit struct pointer (ck_rsa_pkcs_oaep_params* → struct ck_rsa_pkcs_oaep_params*). No other files or fields are modified.

Changes

Cohort / File(s)	Summary
PKCS#11 header API tweak src/lib/pkcs11/pkcs11.h	Member oaep_params in ck_rsa_aes_key_wrap_params now uses explicit type: ck_rsa_pkcs_oaep_params* → struct ck_rsa_pkcs_oaep_params*.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Resolve build error: unknown type name 'ck_rsa_pkcs_oaep_params' by adjusting PKCS#11 header type usage (#810)	✅

Assessment against linked issues: Out-of-scope changes

None found.

Poem

I twitch my ears at structs so neat,
A typedef hop, a pointer treat—
Now oaep_params knows its name,
The build burrows on, all the same.
Thump-thump: regression’s on the run,
Carrots compiled—job well done! 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4f296fa and 2543ad2.

📒 Files selected for processing (1)

• src/lib/pkcs11/pkcs11.h (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: antoinelochet
PR: softhsm/SoftHSMv2#809
File: src/lib/crypto/MLDSAParameters.h:42-44
Timestamp: 2025-08-18T17:59:30.642Z
Learning: In MLDSAParameters.h, the author prefers to keep PKCS#11 constant references (CKP_ML_DSA_*) rather than explicit numeric values for better code clarity and maintainability.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: macOS (botan)
• GitHub Check: macOS (openssl)
• GitHub Check: Windows (x86, openssl)
• GitHub Check: Linux with OpenSSL 3.0
• GitHub Check: Windows (x64, botan)
• GitHub Check: Windows (x64, openssl)
• GitHub Check: Linux with Botan
• GitHub Check: Linux with OpenSSL 1.1.1

🔇 Additional comments (1)

src/lib/pkcs11/pkcs11.h (1)

982-985: Correct fix confirmed: use of struct ck_rsa_pkcs_oaep_params * is consistent and restores buildability.

– Verified there are no remaining occurrences of ck_rsa_pkcs_oaep_params * without the struct keyword.
– Downstream code (tests and SoftHSM) correctly uses the CK_RSA_PKCS_OAEP_PARAMS and CK_RSA_PKCS_OAEP_PARAMS_PTR typedefs.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[bukka]

I think it is better to keep the header synced with p11-kit. It should also note a correct version. The current version was also using just defines frome that header and not the correct param names. All should be fixed in #815