Limit number of sessions #710
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SoftHSMv2 is used for testing PKCS#11 client code before hardware is available, maximum session count on a token needs to be set in order to detects bugs in client code where sessions are leaked and remain open. This can cause problems since most hardware implementations have a limit on opened sessions count. This change sets a limit to general session count.
Contributor
|
Shouldn't this default to the original value or be runtime configurable? Those of us using this entirely in software don't want arbitrary low session limits. |
bjosv
reviewed
Jan 17, 2024
Contributor
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
Additionally, I believe we also need to provide new defines when building with CMake (see config.h.in.cmake and CMakeLists.txt).
Contributor
|
Please rebase on develop and mark as ready when ready. |
Contributor
|
I agree that this way too low default and it should be runtime configurable (ideally through the config). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SoftHSMv2 is used for testing PKCS#11 client code before hardware is available, maximum session count on a token needs to be set in order to detects bugs in client code where sessions are leaked and remain open. This can cause problems since most hardware implementations have a limit on opened sessions count.
This change sets a limit to general session count.