-
Notifications
You must be signed in to change notification settings - Fork 0
[FE] 프론트엔드 배포 파이프라인 workflow 추가 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/gemini review |
1 similar comment
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
코드 변경 사항 검토 결과, 웹 접근성 관련 개선 사항 1건을 제안합니다.
|
|
||
| return ( | ||
| <> | ||
| <h1>Checkmate</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a GitHub Actions-based continuous deployment (CD) pipeline for the frontend application, enabling automated deployment to Google Cloud Storage with CDN cache invalidation. The workflow uses Workload Identity Federation for secure GCP authentication and implements caching strategies for optimal asset delivery.
Changes:
- Added
.github/workflows/fe-cd.ymlworkflow file that triggers on pushes to main branch affecting the frontend directory - Implemented automated build and deployment process using Node.js 24 and pnpm 10
- Configured GCP integration with GCS upload, cache policies, and CDN invalidation
- Added test heading "Checkmate" to App.tsx (likely for testing the deployment pipeline)
- Minor formatting improvement in browser.ts mock setup
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
.github/workflows/fe-cd.yml |
Complete CD pipeline implementation with GCP authentication, build process, GCS deployment, cache configuration, and CDN invalidation |
frontend/src/App.tsx |
Added "Checkmate" heading, likely for testing deployment |
frontend/src/mocks/browser.ts |
Added blank line for formatting consistency |
.DS_Store |
macOS system file that should not be committed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
[P5] 룩굿투미, DDoS도 막아주고~ 캐싱도 해주는~ CDN 아주 좋네요 ^^ |
#️⃣ 변경 사항
#️⃣ 작업 상세 내용
.github/workflows/fe-cd.yml) 구축main브랜치에 push되고, frontend 디렉토리에 변경점이 있을 경우 동작함frozen-lockfile을 통한 의존성 설치 보안 강화gs://checkmate-03/)에 빌드 결과물 업로드 자동화max-age=31536000, immutable설정index.html에 대해 최신 상태 유지를 위한no-cache정책 적용CD 워크플로우 관련 설명
#️⃣ 관련 이슈
📸 스크린샷 (선택)
변경 전
변경 후
📎 참고할만한 자료 (선택)
https://brownbears.tistory.com/602
https://github.com/google-github-actions/upload-cloud-storage
https://coduking.tistory.com/entry/%EA%B9%83%ED%97%88%EB%B8%8C-%EC%95%A1%EC%85%98-GCP-%EC%97%B0%EB%8F%99-%EB%B0%A9%EB%B2%95