-
Notifications
You must be signed in to change notification settings - Fork 22
Refactor model architecture introduce base model and database model separation #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
armanist
merged 8 commits into
softberg:master
from
armanist:372-Refactor-Model-Architecture-Introduce-Base-Model-and-Database-Model-Separation
Jan 23, 2026
Merged
Refactor model architecture introduce base model and database model separation #410
armanist
merged 8 commits into
softberg:master
from
armanist:372-Refactor-Model-Architecture-Introduce-Base-Model-and-Database-Model-Separation
Jan 23, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Separation And related changes on other files
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #410 +/- ##
============================================
+ Coverage 80.65% 80.84% +0.18%
- Complexity 2641 2669 +28
============================================
Files 237 238 +1
Lines 7020 7114 +94
============================================
+ Hits 5662 5751 +89
- Misses 1358 1363 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrey-smaelov
requested changes
Jan 22, 2026
live-soft
approved these changes
Jan 22, 2026
andrey-smaelov
approved these changes
Jan 23, 2026
charoyan88
reviewed
Jan 23, 2026
charoyan88
reviewed
Jan 23, 2026
charoyan88
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a breaking refactor of the model layer (
QtModel→DbModel+ baseModel).Database fetch methods now return new model instances, and create() resets model state to prevent identity leakage.
Please review any code that:
reuses model instances across operations
relies on implicit state mutation after
first()/findOne()/findOneBy()/get()assumes IDs are preserved between
create()callsSee CHANGELOG.md for details.
Closes #372