Support for rails4 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validators in Rails 4.1 deprecated the Validator#setup method and suggested putting it as part of the initializer. In Rails 4.2, the method is fully removed. This commit simply follows the instructions given by the deprecation text.
The previous fix wasn't tested because I was pulling from github and so didn't realize that the model parameter from the old method was being used. This is based on the code in github.com/johncarney/validates_timeliness and is just as tested as the last commit. Will keep updating until it works properly.
The implementation of AttributeAssignment::MultiparameterAttribute in Rails 4.2 was changed, and so the extension from this library was no longer valid. This simple fix lets it more closely match the implementation from the Rails implementation by changing the code in the library to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports Rails 4.2 and removes a deprecation warning in Rails 4.1