[Type] Add streaming deserialization for vector<std::string>#6106
Open
alxbilger wants to merge 1 commit intosofa-framework:masterfrom
Open
[Type] Add streaming deserialization for vector<std::string>#6106alxbilger wants to merge 1 commit intosofa-framework:masterfrom
alxbilger wants to merge 1 commit intosofa-framework:masterfrom
Conversation
alxbilger
added
pr: status to review
Implements `read` functionality for `vector<std::string>`, supporting both bracketed, quoted formats (e.g., `["a", "b"]`) and plain whitespace-separated tokens as a fallback. Includes robust error checking and failure reporting via `std::cerr`. Also adds comprehensive unit tests covering various input formats and expected parsing behaviors for string vectors.
fredroy
force-pushed
the
vectorstringdeserialize
branch
from
ee2d05c to
b019766
Compare
fredroy
approved these changes
May 7, 2026
alxbilger
added
the
pr: AI-aided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: the read/write method for
sofa::type::vector<std::string>are not symmetric.Implements
readfunctionality forvector<std::string>, supporting both bracketed, quoted formats (e.g.,["a", "b"]) and plain whitespace-separated tokens as a fallback. Includes robust error checking and failure reporting viastd::cerr.Also adds comprehensive unit tests covering various input formats and expected parsing behaviors for string vectors.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if