Skip to content

[Framework] Fix more warnings (clang, macos)#6083

Open
fredroy wants to merge 3 commits intosofa-framework:masterfrom
fredroy:fix_more_warnings_framework
Open

[Framework] Fix more warnings (clang, macos)#6083
fredroy wants to merge 3 commits intosofa-framework:masterfrom
fredroy:fix_more_warnings_framework

Conversation

@fredroy
Copy link
Copy Markdown
Contributor

@fredroy fredroy commented Apr 16, 2026

Mostly warning about implicit conversions (real to bool, signed/unsigned, to a smaller type)

The not-trivial one is Sofa/framework/Type/src/sofa/type/Mat.h

  template<typename real2>
    constexpr Mat(const Mat<L,C,real2>& m) noexcept
    {
        std::copy(m.begin(), m.begin()+L, this->begin());
    }

used with CRS templated on blocks (i.e Vec), it can lead conversion (copy) from Vec3f to Vec3d, thus triggering the deprecations set in #5675

NOTE: the AI was a local-deployed one (Qwen3.5)

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status wip Development in the pull-request is still in progress pr: clean Cleaning the code pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Apr 16, 2026
@fredroy
Copy link
Copy Markdown
Contributor Author

fredroy commented Apr 16, 2026

[ci-build][with-all-tests]

Comment thread Sofa/framework/Helper/src/sofa/helper/MarchingCubeUtility.cpp
kFSEventStreamCreateFlagFileEvents // FSEventStreamCreateFlags flags
);
FSEventStreamScheduleWithRunLoop(m_eventStream,CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
FSEventStreamSetDispatchQueue(m_eventStream, dispatch_get_main_queue());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc says "Schedules the stream on the specified dispatch queue." where dispatch_get_main_queue() is the dispatch queue to use to receive events

The documentation also states that FSEventStreamSetDispatchQueue is now deprecated and the new function is advised to be used

So 👍

Comment thread Sofa/framework/Type/src/sofa/type/DualQuat.inl
@fredroy fredroy force-pushed the fix_more_warnings_framework branch from 00b6ee9 to 275ba4a Compare May 8, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants