Skip to content

Fixed element for lower triangular part of BTDMatrix#6050

Open
MakiRuse wants to merge 1 commit intosofa-framework:masterfrom
MakiRuse:btd_correction
Open

Fixed element for lower triangular part of BTDMatrix#6050
MakiRuse wants to merge 1 commit intosofa-framework:masterfrom
MakiRuse:btd_correction

Conversation

@MakiRuse
Copy link

The method element of BTDMatrix returns 0 only for the upper trianguar part of the matrix but not for the lower part. This results in a wrong display of the matrix for debug and if access is done through the "element" method, the resulting data will be wrong as well.

I propose this quick fix to also ignore the lower triangular part of the matrix when outside of the tridiagonal blocks.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant