Skip to content

[Simulation.Core] Add warning if RequiredPlugin uses its name to load a plugin #6038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alxbilger wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Open

[Simulation.Core] Add warning if RequiredPlugin uses its name to load a plugin #6038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Sofa/framework/Simulation/Core/src/sofa/simulation/RequiredPlugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,18 @@ bool RequiredPlugin::loadPlugin()
/// In case the pluginName is not set we copy the provided name into the set to load.
if(!d_pluginName.isSet() && name.isSet())
{
pluginsToLoad.push_back(this->getName());
const auto componentName = this->getName();
{
const auto considerNameAsPluginName = FileSystem::cleanPath(componentName);
if (FileSystem::isFile(considerNameAsPluginName) || !pluginManager.findPlugin(considerNameAsPluginName).empty())
{
msg_deprecated() << "The name of the plugin to load (" << componentName
<< ") must be defined in the Data '" << d_pluginName.getName()
<< "', not in the the Data '" << this->name.getName() << "'. The plugin '"
<< componentName << "' may be loaded, but this may change in the future.";
}
}
pluginsToLoad.push_back(componentName);
}

type::vector< std::string > failed;
Expand Down
Loading