[Mapping.Linear] Add applyJT for matrices for IdentityMultiMapping#6033
Open
alxbilger wants to merge 2 commits intosofa-framework:masterfrom
Open
[Mapping.Linear] Add applyJT for matrices for IdentityMultiMapping#6033alxbilger wants to merge 2 commits intosofa-framework:masterfrom
alxbilger wants to merge 2 commits intosofa-framework:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #6032
The goal was to verify that the two following scenes produce the same behaviour:
Both scene should produce the same result. Except that the scene with the mapping has a problem. See the system matrix:
The mass matrix is missing. It's because
IdentityMultiMappingdoes not implementapplyJTfor matrices.With this PR, the system matrices is now:

Note:
IdentityMultiMappingis not available in<Vec3,Vec2>, but I made sure that the current implementation is compatible with such templates. For example, I tried the following scene:The system matrix is:

It is rank-deficient, but it is expected (the mass is computed in 2d, not in 3d. One component is missing). So it works as expected.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if