Skip to content

[Type] Quat: factorize matrix code#6030

Open
fredroy wants to merge 1 commit intosofa-framework:masterfrom
fredroy:quat_buildrotmat
Open

[Type] Quat: factorize matrix code#6030
fredroy wants to merge 1 commit intosofa-framework:masterfrom
fredroy:quat_buildrotmat

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Mar 18, 2026

Noticed that quat::toMatrix (and different names) is duplicated 4 times, with the homgeneous variant: each with different input or output (c-array, template, Mat3x3, opengl-transposed)
Asked Claude how to factorize this code without any copy or anything, and its solution is quite elegant I must say 🫢

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI labels Mar 18, 2026
@alxbilger
Copy link
Contributor

[ci-build][with-all-tests]

@th-skam th-skam added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants