[ODESolver.Forward] Support mapped masses in EulerExplicitSolver#6000
Open
alxbilger wants to merge 2 commits intosofa-framework:masterfrom
Open
[ODESolver.Forward] Support mapped masses in EulerExplicitSolver#6000alxbilger wants to merge 2 commits intosofa-framework:masterfrom
alxbilger wants to merge 2 commits intosofa-framework:masterfrom
Conversation
alxbilger
added
pr: enhancement
Contributor
|
[ci-build][with-all-tests] |
hugtalbot
added
the
pr: highlighted in next release
Collaborator
|
[ci-depends-on] detected during build #4. To unlock the merge button, you must
|
fredroy
force-pushed
the
forwardeulermappedmass
branch
from
ea73dd7 to
697284e
Compare
th-skam
reviewed
Mar 18, 2026
Sofa/Component/ODESolver/Forward/src/sofa/component/odesolver/forward/EulerExplicitSolver.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
+389
to
+390
| sofa::simulation::MappingGraph mappingGraph; | ||
| mappingGraph.build(params, this->getContext()); |
Contributor
There was a problem hiding this comment.
Curiosity, is this something costly to do at every solve? or trivial?
Contributor
Author
There was a problem hiding this comment.
not measured but I plan to cache it. Building the mapping graph should not be costly on a small scene graph. For example, the mapping graph is also built by the matrix assembly every time step.
th-skam
approved these changes
Mar 19, 2026
th-skam
added
pr: status ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #5991
Fixes #5999
Relevant commit: fdd47c0
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if