Skip to content

fix: the socket in socket.ts #5494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −0
Open

fix: the socket in socket.ts #5494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/engine.io/lib/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,11 @@ export interface ServerOptions {
* @default false
*/
allowEIO3?: boolean;
/**
* the maximum number of simultaneous connections. Any connection attempt above this threshold will be rejected.
* @default Infinity
*/
maxConnections?: number;
}

/**
Expand Down Expand Up @@ -454,6 +459,26 @@ export abstract class BaseServer extends EventEmitter {
return;
}

if (
this.opts.maxConnections != null &&
this.clientsCount >= this.opts.maxConnections
) {
debug(
"too many connections (maxConnections=%d)",
this.opts.maxConnections,
);
this.emit("connection_error", {
req,
code: Server.errors.FORBIDDEN,
message: Server.errorMessages[Server.errors.FORBIDDEN],
context: {
name: "CONNECTION_LIMIT_EXCEEDED",
},
});
closeConnection(Server.errors.FORBIDDEN);
return;
}

let id;
try {
id = await this.generateId(req);
Expand Down