This repository was archived by the owner on Dec 5, 2021. It is now read-only.
IsConnected now includes a check on sender==null. #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise callls to this method always return True and if(!TelegramClient.IsConnected) TelegramClient.ConnectAsync() wouldn't have the expected result.
Collaborator
|
hey @salarcode sorry to bother you, but as you implemented this IsConnected property, I thought you might be interested in reviewing this PR? thanks in advance |
+ TcpTransport has got a connect method which properly initializes the underlying tcpclient
Contributor
Author
|
moved to #931 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise callls to this method always return True and if(!TelegramClient.IsConnected) TelegramClient.ConnectAsync() wouldn't have the expected result.