feat(IDE-1652): introduce LsSettingsRegistry, protocol message objects (1/3) by nick-y-snyk · Pull Request #394 · snyk/snyk-eclipse-plugin

nick-y-snyk · 2026-05-18T12:50:12Z

User description

Summary

First of three PRs splitting feat/IDE-1652. Introduces foundational types required by the upcoming LS settings rewrite — all new classes are unreferenced by existing code, so this is safe to land standalone.

LsKey — typed enum of all LS settings fields
LsFolderSettingsKeys — constants for folder-scoped LS config fields
LsSettingsRegistry — single source of truth mapping each LsKey to its Preferences key, default value, and change-tracking metadata
ConfigSetting — wire-format value object for a single LS setting ({ value, changed })
LspFolderConfig — wire-format value object for per-folder LS config
LspConfigurationParam — top-level outbound LS config payload (settings, folderConfigs, integrationName, requiredProtocolVersion, trustedFolders)
Preferences.ACTIVATE_SNYK_SECRETS — constant needed by LsSettingsRegistry (additive, one line)
LsBinaries — minor update

Tests cover each value object and serialisation round-trips via Gson.

PR sequence

PR	Scope
This PR (1/3)	Foundation: registry, protocol POJOs
[2/3]	Wiring: inbound `$/snyk.configuration`, outbound `LspConfigurationParam`, `FolderConfigSettings`, change tracking
[3/3]	HTML settings page migration onto new store
PR #393	All deletions: legacy POJOs + native UI

Test plan

./mvnw test -pl plugin,tests passes
./mvnw pmd:check -pl plugin — zero violations

PR Type

Enhancement

Description

Introduce LsKey enum and LsSettingsRegistry for centralized setting management.
Add protocol message objects: ConfigSetting, LspFolderConfig, LspConfigurationParam.
Establish foundation for Language Server settings rewrite.
Include unit tests and dependency for new data structures.

Diagram Walkthrough

flowchart LR
  A[LsKey Enum] --> B(LsSettingsRegistry);
  B --> C(ConfigSetting);
  B --> D(LspFolderConfig);
  B --> E(LspConfigurationParam);
  F[Preferences.java Add] --> B;
  G[LsBinaries.java Update] --> B;
  H[MANIFEST.MF Add Gson] --> C;
  H --> D;
  H --> E;
  I[Tests for New Objects] --> C;
  I --> D;
  I --> E;

File Walkthrough

Relevant files

Enhancement

8 files

Preferences.java `Add ACTIVATE_SNYK_SECRETS preference constant`	+1/-0
LsFolderSettingsKeys.java `Define constants for folder-scoped LS settings`	+18/-0
LsKey.java `Introduce LsKey enum for LS setting keys`	+41/-0
LsSettingsRegistry.java `Create central registry for LS settings and preferences`	+225/-0
LsBinaries.java `Update required LS protocol version`	+1/-1
ConfigSetting.java `Define ConfigSetting value object`	+61/-0
LspConfigurationParam.java `Define LspConfigurationParam payload object`	+119/-0
LspFolderConfig.java `Define LspFolderConfig value object for per-folder settings`	+74/-0

Tests

3 files

ConfigSettingTest.java `Add unit tests for ConfigSetting`	+149/-0
LspConfigurationParamTest.java `Add unit tests for LspConfigurationParam`	+135/-0
LspFolderConfigTest.java `Add unit tests for LspFolderConfig`	+330/-0

Dependencies

1 files

MANIFEST.MF `Add Gson dependency`	+1/-0

…s, and ACTIVATE_SNYK_SECRETS constant Adds the foundational types needed for the upcoming LS settings rewrite: - LsKey enum: typed keys for all LS settings fields - LsFolderSettingsKeys: constants for folder-scoped LS config fields - LsSettingsRegistry: single source of truth mapping LsKey entries to Preferences keys, defaults, and change-tracking metadata - ConfigSetting: wire-format value object for a single LS setting - LspFolderConfig: wire-format value object for per-folder LS config - LspConfigurationParam: top-level outbound LS config payload - Preferences.ACTIVATE_SNYK_SECRETS: constant required by LsSettingsRegistry - LsBinaries: minor update All new classes are unreferenced by existing code — safe to land standalone. Tests cover each value object and serialisation round-trips.

snyk-io · 2026-05-18T12:50:24Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

…cture Deletes all code made dead by the new LsSettingsRegistry / FolderConfigSettings / LspConfigurationParam architecture landed in PRs #394, #395, #396: Native settings UI (no callers after HTML-only migration): - PreferencesPage, TokenFieldEditor, NativeProjectPropertyPage - SnykPreferencePageFactoryTest, ProjectPropertyPageFactoryTest Legacy LS protocol POJOs (replaced by LspConfigurationParam / ConfigSetting / LspFolderConfig / FolderConfigSettings): - Settings, FolderConfig, FolderConfigsParam, FolderConfigs, IdeConfigData - FolderConfigTest

bastiandoetsch

Automated review findings — see inline comments. — AI review

bastiandoetsch · 2026-05-19T09:11:42Z

+        // formDeserializer: form sends "auto"/"manual", pref stores "true"/"false".
+        entries.put(LsKey.SCANNING_MODE, new Entry(LsKey.SCANNING_MODE, Preferences.SCANNING_MODE_AUTOMATIC, "true",
+                v -> Boolean.parseBoolean(v),
+                value -> String.valueOf("automatic".equals(String.valueOf(value))),


[Critical] SCANNING_MODE inbound deserializer always stores "false" regardless of the LS value. The LS sends a JSON boolean for scan_automatic; String.valueOf(Boolean.TRUE) is "true", not "automatic", so "automatic".equals("true") is always false. Every inbound $/snyk.configuration push silently resets automatic scanning to manual.

Fix: check for both the boolean true and the legacy string:

value -> String.valueOf(Boolean.TRUE.equals(value) || "automatic".equals(String.valueOf(value)))

Add a round-trip test: serialize with outboundDefault="true" and verify inbound restores "true".

— AI review

Fixed: inbound deserializer now uses Boolean.TRUE.equals(value) — handles LS boolean directly, dropped legacy string fallback.

— Claude Code

bastiandoetsch · 2026-05-19T09:11:42Z

+         * Used by HTMLSettingsPreferencePage for form-specific deserialization.
+         * null = use the standard applyFormValue path (raw nodeToString).
+         */
+        public final Function<com.fasterxml.jackson.databind.JsonNode, String> formDeserializer;


[Should Fix] Entry.formDeserializer is typed as Function<com.fasterxml.jackson.databind.JsonNode, String> — a fully-qualified Jackson reference with no import — encoding an HTMLSettingsPreferencePage (UI layer) parsing concern directly into the io.snyk.languageserver (infrastructure) package. PR 3/3 is described as migrating off the HTML settings form; these two fields (formDeserializer, useInFallbackForm) become dead weight in the foundational Entry type after that.

Fix: remove formDeserializer and useInFallbackForm from Entry; move the form-parsing lambdas into HTMLSettingsPreferencePage as a local Map<LsKey, Function<JsonNode, String>>. This keeps LsSettingsRegistry free of UI-layer and Jackson coupling.

— AI review

HTML settings page is staying long-term — formDeserializer and useInFallbackForm remain relevant. Fully-qualified Jackson name is valid Java without import.

— Claude Code

bastiandoetsch · 2026-05-19T09:11:42Z

+         * Additional pref keys whose changed-state ORed with prefKey's to compute the changed flag.
+         * Used for severity filters that share a changed flag across 4 keys.
+         */
+        public final String[] additionalChangedPrefKeys;


[Should Fix] additionalChangedPrefKeys is a public final String[] — a mutable array directly exposed on a public field. Any caller can overwrite array elements, violating the registry's single-source-of-truth guarantee.

Fix: change the field to public final List<String> additionalChangedPrefKeys (or keep String[] with a defensive copy in the getter). Update the factory methods and consumers accordingly.

— AI review

Agreed on the principle, but String[] is only assigned at construction and never mutated in practice. Deferring — cosmetic-only change with no behavioral risk.

— Claude Code

bastiandoetsch · 2026-05-19T09:11:42Z

 	public static final String ACTIVATE_SNYK_CODE_SECURITY = "ACTIVATE_SNYK_CODE_SECURITY";
 	public static final String ACTIVATE_SNYK_OPEN_SOURCE = "ACTIVATE_SNYK_OPEN_SOURCE";
 	public static final String ACTIVATE_SNYK_IAC = "ACTIVATE_SNYK_IAC";
+	public static final String ACTIVATE_SNYK_SECRETS = "ACTIVATE_SNYK_SECRETS";


[Should Fix] ACTIVATE_SNYK_SECRETS has no insecureStore.setDefault() call. Every other ACTIVATE_* flag (ACTIVATE_SNYK_CODE_SECURITY, ACTIVATE_SNYK_OPEN_SOURCE, ACTIVATE_SNYK_IAC) has a corresponding setDefault at lines 125–127. Without this, getDefaultString(ACTIVATE_SNYK_SECRETS) returns an empty string; any caller using a true fallback in getBooleanPref will silently return true instead of the intended false.

Fix: add to the constructor defaults block:

insecureStore.setDefault(ACTIVATE_SNYK_SECRETS, FALSE);

Also add ACTIVATE_SNYK_SECRETS to migratePreferences() if it can be stored via store().

— AI review

PR #395 replaces all individual setDefault calls with a registry-driven loop — ACTIVATE_SNYK_SECRETS picks up its false default automatically from Entry.outboundDefault.

— Claude Code

bastiandoetsch · 2026-05-19T09:11:42Z

+    INSECURE("proxy_insecure"),
+    ADDITIONAL_PARAMS("additional_parameters"),
+    SCANNING_MODE("scan_automatic"),
+    ADDITIONAL_ENV("additional_environment"),


[Should Fix] ADDITIONAL_ENV, ENABLE_TELEMETRY, and DEVICE_ID are declared in the enum but have no entry in LsSettingsRegistry.ENTRIES and no comment explaining their routing. ADDITIONAL_ENV maps to additional_environment, which the existing LsConfigurationUpdater actively sends; when PR 2/3 migrates callers to the registry, this setting will be silently dropped from all outbound LS configuration pushes.

Fix: either add ADDITIONAL_ENV to ENTRIES, or add inline Javadoc on each absent member explaining the alternative routing path (e.g., env-var path for ENABLE_TELEMETRY, top-level InitializationOptions field for DEVICE_ID, runtime env for ADDITIONAL_ENV).

— AI review

DEVICE_ID is sent as a top-level LspConfigurationParam field in PR #395, not via the settings map. ENABLE_TELEMETRY removal is intentional — superseded by SEND_ERROR_REPORTS. ADDITIONAL_ENV omission is intentional and tracked in Jira for a follow-up PR adding global+folder-scoped env support.

— Claude Code

bastiandoetsch · 2026-05-19T09:11:42Z

+			return false;
+		}
+		if (a instanceof Number && b instanceof Number) {
+			return ((Number) a).doubleValue() == ((Number) b).doubleValue();


[Should Fix] ((Number) a).doubleValue() == ((Number) b).doubleValue() returns false when either value is Double.NaN (IEEE 754: NaN != NaN). If the LS sends NaN for a numeric setting, withSettingIfChanged generates a new copy and marks it changed on every call, flooding the LS with redundant configuration-change events.

Fix:

return Double.compare(((Number) a).doubleValue(), ((Number) b).doubleValue()) == 0;

Double.compare treats NaN as equal to NaN and handles all edge cases correctly.

— AI review

Fixed: use Double.compare() to handle NaN correctly.

— Claude Code

bastiandoetsch · 2026-05-19T09:11:42Z

+    /**
+     * Ordered outbound entries keyed by LsKey.
+     * Iterated by LsConfigurationUpdater.buildConfigurationParam().
+     * EnumMap preserves insertion order.


[Suggestion] The comment "EnumMap preserves insertion order" is incorrect. EnumMap preserves enum declaration order (the order of LsKey members), not insertion order. If LsKey members are reordered for any reason, the outbound serialization sequence changes silently.

Fix: correct to: // EnumMap preserves LsKey declaration order; reordering LsKey members changes the outbound config sequence.

— AI review

Fixed: corrected comment — EnumMap preserves declaration order, not insertion order.

— Claude Code

bastiandoetsch · 2026-05-19T09:11:42Z

+		copy.settings = new HashMap<>();
+
+		if (this.settings != null) {
+			for (Map.Entry<String, ConfigSetting> entry : this.settings.entrySet()) {


[Suggestion] The entrySet() loop copies the map manually where the HashMap copy constructor suffices.

Fix: replace lines 32–37 with:

copy.settings = new HashMap<>(this.settings);

— AI review

Fixed: use HashMap copy constructor.

— Claude Code

bastiandoetsch · 2026-05-19T13:10:37Z

/describe

snyk-pr-review-bot · 2026-05-19T13:11:21Z

PR Description updated to latest commit (e7da17c)

bastiandoetsch · 2026-05-19T13:25:49Z

/describe

snyk-pr-review-bot · 2026-05-19T13:26:26Z

PR Description updated to latest commit (e7da17c)

bastiandoetsch · 2026-05-19T13:28:52Z

/describe

snyk-pr-review-bot · 2026-05-19T13:29:32Z

PR Description updated to latest commit (e7da17c)

LS sends scan_automatic as a JSON boolean. The previous deserializer checked "automatic".equals(String.valueOf(value)) which always evaluates to false when value is Boolean.TRUE, silently resetting scanning to manual on every inbound $/snyk.configuration push.

…cture Deletes all code made dead by the new LsSettingsRegistry / FolderConfigSettings / LspConfigurationParam architecture landed in PRs #394, #395, #396: Native settings UI (no callers after HTML-only migration): - PreferencesPage, TokenFieldEditor, NativeProjectPropertyPage - SnykPreferencePageFactoryTest, ProjectPropertyPageFactoryTest Legacy LS protocol POJOs (replaced by LspConfigurationParam / ConfigSetting / LspFolderConfig / FolderConfigSettings): - Settings, FolderConfig, FolderConfigsParam, FolderConfigs, IdeConfigData - FolderConfigTest

snyk-pr-review-bot · 2026-05-20T13:04:21Z

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Mandatory Binary Download 🟠 [major] Bumping `REQUIRED_LS_PROTOCOL_VERSION` to '25' will trigger a mandatory download of the Snyk Language Server binary for all users upon the next plugin startup. If the Language Server version matching this protocol is not yet available on the download server, or if the user is in an environment with restricted downloads, the plugin may fail to start correctly or default to a broken state. This is because `SnykStartup.downloadLS()` returns true if the version stored in preferences does not match this constant. public static final String REQUIRED_LS_PROTOCOL_VERSION = "25"; Loose Equality Check 🟡 [minor] The `valuesEqual` method uses `String.valueOf(a).equals(String.valueOf(b))` as a final fallback. This can lead to false positives (treating logically different objects as equal) or false negatives (triggering unnecessary LS notifications) if objects have complex or non-deterministic `toString()` implementations. For configuration objects, this might cause the `changed` flag to be set to `true` incorrectly, leading to excessive protocol traffic. return Objects.equals(String.valueOf(a), String.valueOf(b));
📚 Repository Context Analyzed This review considered 53 relevant code sections from 15 files (average relevance: 0.95) plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java (lines 1-100) plugin/src/main/java/io/snyk/languageserver/LsConfigurationUpdater.java (lines 1-98) plugin/src/main/java/io/snyk/languageserver/protocolextension/messageObjects/Settings.java (lines 1-100) plugin/src/main/java/io/snyk/eclipse/plugin/preferences/IdeConfigData.java (lines 1-86) plugin/src/main/java/io/snyk/languageserver/LsRuntimeEnvironment.java (lines 1-100) plugin/src/main/java/io/snyk/eclipse/plugin/domain/ProductConstants.java (lines 1-48) plugin/src/main/java/io/snyk/languageserver/SnykLanguageServer.java (lines 1-100) ... and 8 more file(s)

acke

Re-review (review-orchestrator)

Verdict: APPROVE WITH NITS

Verification of prior comments

#	Severity	File:Line	Status
1	Critical	`LsSettingsRegistry.java:126` SCANNING_MODE inbound	✅ Fixed (see new pass C1 — legacy string payloads now silently flip to manual)
2	Should-Fix	`LsSettingsRegistry.java:44` formDeserializer coupling	⏸️ Declined (HTML page stays — accepted)
3	Should-Fix	`LsSettingsRegistry.java:38` mutable `String[]`	⏸️ Deferred (cosmetic)
4	Should-Fix	`Preferences.java:49` ACTIVATE_SNYK_SECRETS setDefault	⏸️ Deferred to #395 (will verify there)
5	Should-Fix	`LsKey.java:14/16/33` undocumented absent members	❌ Partially — see new pass C1
6	Should-Fix	`LspFolderConfig.java:70` NaN comparison	✅ Fixed
7	Suggestion	`LsSettingsRegistry.java:100` EnumMap-order comment	✅ Fixed
8	Suggestion	`LspFolderConfig.java:35` HashMap copy constructor	✅ Fixed

New pass findings (4)

🟡 Medium LsKey.java:14,16,33 — absent enum members lack Javadoc explaining routing
🟡 Medium LsFolderSettingsKeys.java:11 — ADDITIONAL_PARAMETERS wire string duplicates LsKey.ADDITIONAL_PARAMS.key
🟡 Medium LsSettingsRegistry.java:124 — fixed SCANNING_MODE deserializer silently treats non-boolean-true (incl. null, string "true") as "false"
🔵 Low LsFolderSettingsKeys.java:12 — ADDITIONAL_ENV wire string differs from LsKey.ADDITIONAL_ENV (intentional; needs comment)

See inline comments for full block-formatted findings.

Cross-PR: please verify in #395 that the registry-driven default loop actually picks up ACTIVATE_SNYK_SECRETS. If not, please add insecureStore.setDefault(ACTIVATE_SNYK_SECRETS, FALSE) here before merge.

Manifest: .claude/reviews/394/TOOLS_USED.md
— AI review comment

acke · 2026-05-21T15:40:45Z

+    INSECURE("proxy_insecure"),
+    ADDITIONAL_PARAMS("additional_parameters"),
+    SCANNING_MODE("scan_automatic"),
+    ADDITIONAL_ENV("additional_environment"),


🟡 Medium

[LsKey.java:14,16,33] ADDITIONAL_ENV, ENABLE_TELEMETRY, and DEVICE_ID remain in the enum without inline Javadoc explaining why they have no ENTRIES row. The author's rationale (DEVICE_ID is top-level on LspConfigurationParam; ENABLE_TELEMETRY is superseded by SEND_ERROR_REPORTS; ADDITIONAL_ENV deferred) was given in the prior thread but lives only there — a future reader of LsKey.java or LsSettingsRegistry will see the missing entries and assume it's a bug.

Fix:
Add a one-line Javadoc per absent member, e.g.:

/** Sent as top-level field on LspConfigurationParam — not via settings map. */ DEVICE_ID("device_id"), /** Superseded by SEND_ERROR_REPORTS; kept for backward compatibility with stored prefs. */ ENABLE_TELEMETRY("enableTelemetry"), /** Folder-scoped variant uses LsFolderSettingsKeys.ADDITIONAL_ENV; global routing tracked in IDE-XXXX. */ ADDITIONAL_ENV("additional_environment"),

— AI review comment

acke · 2026-05-21T15:40:59Z

+
+	public static final String BASE_BRANCH = "base_branch";
+	public static final String PREFERRED_ORG = "preferred_org";
+	public static final String ADDITIONAL_PARAMETERS = "additional_parameters";


🟡 Medium

[LsFolderSettingsKeys.java:11] LsFolderSettingsKeys.ADDITIONAL_PARAMETERS = "additional_parameters" duplicates LsKey.ADDITIONAL_PARAMS.key = "additional_parameters". Two separate source-of-truth constants for the same wire string — if one is renamed/changed and the other isn't, the outbound payload silently desyncs between global and folder scope.

Fix:
Make the folder-scope constant an alias:

public static final String ADDITIONAL_PARAMETERS = LsKey.ADDITIONAL_PARAMS.key;

Or add a unit test asserting the two strings stay equal so a future rename fails CI.

— AI review comment

acke · 2026-05-21T15:41:01Z

+        entries.put(LsKey.ACTIVATE_SNYK_SECRETS,  Entry.bool(LsKey.ACTIVATE_SNYK_SECRETS, Preferences.ACTIVATE_SNYK_SECRETS, false));
+        entries.put(LsKey.SCANNING_MODE, new Entry(LsKey.SCANNING_MODE, Preferences.SCANNING_MODE_AUTOMATIC, "true",
+                v -> Boolean.parseBoolean(v),
+                value -> String.valueOf(Boolean.TRUE.equals(value)),


🟡 Medium

[LsSettingsRegistry.java:124] The prior Critical fix dropped the legacy "automatic"-string fallback (value -> String.valueOf(Boolean.TRUE.equals(value))). Now any non-Boolean.TRUE payload — including string "true", or null — silently maps to "false" and flips the user's pref to manual. Acceptable only if the LS contract guarantees scan_automatic is always a JSON boolean.

Fix:
Either (a) tighten to handle both shapes defensively:

value -> { if (Boolean.TRUE.equals(value)) return "true"; if (Boolean.FALSE.equals(value)) return "false"; String s = String.valueOf(value); if ("true".equalsIgnoreCase(s) || "automatic".equals(s)) return "true"; if ("false".equalsIgnoreCase(s) || "manual".equals(s)) return "false"; return Preferences.getInstance().getPref(Preferences.SCANNING_MODE_AUTOMATIC); }

Or (b) leave as-is and add a unit test pinning the assumption (Boolean.FALSE → "false", string "true" → "false", null → "false") so the regression is intentional and visible.

— AI review comment

acke · 2026-05-21T15:41:02Z

+	public static final String BASE_BRANCH = "base_branch";
+	public static final String PREFERRED_ORG = "preferred_org";
+	public static final String ADDITIONAL_PARAMETERS = "additional_parameters";
+	public static final String ADDITIONAL_ENV = "additional_env";


🔵 Low

[LsFolderSettingsKeys.java:12] LsFolderSettingsKeys.ADDITIONAL_ENV = "additional_env" vs LsKey.ADDITIONAL_ENV("additional_environment") — different wire strings for folder-scope vs global. Likely intentional but easy to confuse. A one-line comment would prevent future "fix" PRs that try to unify them.

Fix:

/** Folder-scoped env (global counterpart uses "additional_environment" via LsKey.ADDITIONAL_ENV). */ public static final String ADDITIONAL_ENV = "additional_env";

— AI review comment

acke

approved with nits

nick-y-snyk requested a review from a team as a code owner May 18, 2026 12:50

nick-y-snyk mentioned this pull request May 18, 2026

feat(IDE-1652): add inbound $/snyk.configuration handler and outbound updater (2/3) #395

Open

3 tasks

This comment has been minimized.

Sign in to view

nick-y-snyk mentioned this pull request May 18, 2026

feat(IDE-1652): migrate HTML settings page onto FolderConfigSettings + ExecuteCommandBridge (3/3) #396

Open

3 tasks

nick-y-snyk mentioned this pull request May 18, 2026

refactor(IDE-1652): remove native settings UI and legacy FolderConfig infrastructure #393

Open

2 tasks

bastiandoetsch reviewed May 19, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

nick-y-snyk added 2 commits May 20, 2026 14:48

fix: use Double.compare for NaN-safe numeric equality in LspFolderConfig

b57e0c2

fix: correct EnumMap ordering comment in LsSettingsRegistry

4088113

refactor: use HashMap copy constructor in LspFolderConfig.withSetting

ee73f3d

nick-y-snyk requested a review from bastiandoetsch May 20, 2026 13:03

acke reviewed May 21, 2026

View reviewed changes

acke approved these changes May 21, 2026

View reviewed changes

Conversation

nick-y-snyk commented May 18, 2026 • edited by snyk-pr-review-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Summary

PR sequence

Test plan

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

snyk-io Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

This comment has been minimized.

bastiandoetsch left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bastiandoetsch commented May 19, 2026

Uh oh!

snyk-pr-review-bot Bot commented May 19, 2026

Uh oh!

bastiandoetsch commented May 19, 2026

Uh oh!

snyk-pr-review-bot Bot commented May 19, 2026

Uh oh!

bastiandoetsch commented May 19, 2026

Uh oh!

snyk-pr-review-bot Bot commented May 19, 2026

Uh oh!

This comment has been minimized.

snyk-pr-review-bot Bot commented May 20, 2026

PR Reviewer Guide 🔍

Uh oh!

acke left a comment

Choose a reason for hiding this comment

Re-review (review-orchestrator)

Verification of prior comments

New pass findings (4)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nick-y-snyk commented May 18, 2026 •

edited by snyk-pr-review-bot Bot

Loading

snyk-io Bot commented May 18, 2026 •

edited

Loading