-
Notifications
You must be signed in to change notification settings - Fork 670
feat: enable go std libs for cli #6427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
c373cca to
916d7ae
Compare
916d7ae to
705d65d
Compare
8f08680 to
9f18d6d
Compare
9f18d6d to
51cf6ac
Compare
51cf6ac to
534f7ae
Compare
| options: Options & (TestOptions | MonitorOptions), | ||
| ): Promise<any> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest: keep it type-safe, return Promise<Options & (TestOptions | MonitorOptions)>
|
|
||
| // Plugin configuration options | ||
| configuration?: { | ||
| includeGoStandardLibraryDeps?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: the options interface is a big, ambiguous thing. can we add some context to this properties via a comment? e.g. project-id does a similar thing:
// Used only with the Code (SAST) plugin. Allows running tests with reporting for existing projects.
'project-id'?: string;
2e289a3 to
459e528
Compare
459e528 to
4e48c06
Compare
What does this PR do?
Adds a feature flag that will include Go's standard library packages in the dep-graph.
Any background context you want to provide?
This is a request from #deal-elastic
What are the relevant tickets?
https://snyksec.atlassian.net/browse/OSM-3197?focusedCommentId=1305540