-
Notifications
You must be signed in to change notification settings - Fork 670
Fetch Feature Flag with call to Feature Flag Gateway Api #6398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brew42
wants to merge
2
commits into
main
Choose a base branch
from
feature/CSENG-68_AddFFG
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee6339b to
0583fce
Compare
980cd8c to
7102dbb
Compare
7102dbb to
08bcc34
Compare
snyk-abedonik
approved these changes
Dec 30, 2025
08bcc34 to
70dbb05
Compare
PeterSchafer
reviewed
Jan 5, 2026
PeterSchafer
reviewed
Jan 5, 2026
PeterSchafer
reviewed
Jan 5, 2026
PeterSchafer
reviewed
Jan 5, 2026
PeterSchafer
reviewed
Jan 5, 2026
PeterSchafer
reviewed
Jan 5, 2026
269693b to
6d7616f
Compare
583dea5 to
e7db026
Compare
Contributor
|
e7db026 to
c4e7766
Compare
cliv2/internal/proxy/interceptor/legacyfeatureflaginterceptor.go
Outdated
Show resolved
Hide resolved
cliv2/internal/proxy/interceptor/legacyfeatureflaginterceptor_test.go
Outdated
Show resolved
Hide resolved
10abbbe to
344ec8b
Compare
344ec8b to
bfef493
Compare
00a6e35 to
af4c8bf
Compare
chore: link to osflow and gaf built versions [CSENG-68] chore: correct unit test [CSENG-68] chore: update processWorkspacesProjects with flags [CSENG-68] chore: handle pnpm build [CSENG-68] chore: revert python update [CSENG-68] chore: revert node js lock file parser [CSENG-68] chore: revert change
af4c8bf to
2b7c3c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Adds an interceptor for the registry call to fetch feature flags 'show-maven-build-scope' and ''show-npm-scope' from the gaf configuration
See /cli/cliv2/internal/proxy/interceptor/registryinjector.go
Pass this feature flag to the maven and npm plugins -> Plugin call to feature flag gateway from src/lib/snyk-test/index.js and pass flags to src/lib/plugins/get-single-plugin-result.ts where the mvn plugin is invoked with feature flag.
Where should the reviewer start?
/cli/cliv2/internal/proxy/interceptor/registryinjector.go
New Interceptor
src/lib/snyk-test/index.js
Call Feature Flag Gateway and set flag in featureFlags
src/lib/plugins/get-single-plugin-result.ts
Update to pass feature flag to maven/npm plugin
How should this be manually tested?
-- Maven--
Generate sbom for maven project
Run sbom generation for org with and without the show-maven-build-scope feature flag enabled in flipt.
cli/binary-releases/snyk-macos-arm64 sbom --format cyclonedx1.6+json --debugRun sbom generation for user authenticated with group service account token. Confirm default organization is passed to feature flag call scope is generated as expected.
cli/binary-releases/snyk-macos-arm64 auth <token>Flag enabled - sbom output contains scope
Flag disabled - sbom output does not contain scope
-- Npm--
Generate sbom for npm project
cli/binary-releases/snyk-macos-arm64 sbom --format cyclonedx1.6+json --debugFlag enabled - sbom output contains scope
Flag disabled - sbom output does not contain scope
What's the product update that needs to be communicated to CLI users?
Sbom generated output will contain maven scope information for those organizations with the 'show-maven-build-scope' feature flag enabled
Sbom generated output will contain npm scope information for those organizations with the 'show-npm-scope' feature flag enabled