Skip to content

Fix 1.44 compatibility #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
R4356th merged 2 commits into from
Jul 11, 2025
Merged

Fix 1.44 compatibility #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
647441e
Add import for namespaced Html class
SomeMWDev Jul 8, 2025
17a1860
Use rawElement instead of concatenating
SomeMWDev Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"license-name": "GPLv3",
"type": "parserhook",
"requires": {
"MediaWiki": ">=1.35.0"
"MediaWiki": ">=1.40.0"
},
"AutoloadClasses": {
"EmbedSnap": "includes/EmbedSnap.php"
Expand Down
15 changes: 10 additions & 5 deletions includes/EmbedSnap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@
*/

use MediaWiki\Hook\ParserFirstCallInitHook;
use MediaWiki\Html\Html;

if ( !defined( 'MEDIAWIKI' ) ) {
die( 'Snap! Project Embed requires MediaWiki 1.35 or later to run.' );
}

class EmbedSnap implements ParserFirstCallInitHook {
/** Register <snap> and <snap-project> tags */
/** Register <snap> and <snap-project> tags */
public function onParserFirstCallInit( $parser ) {
$parser->setHook( 'snap', [ __CLASS__,'renderEmbedSnap' ] );
$parser->setHook( 'snap-project', [ __CLASS__,'renderEmbedSnap' ] );
Expand All @@ -41,9 +42,9 @@ public static function renderEmbedSnap( $input, $argv, $parser ) {
$pause = '';
$hide = '';
$elementtorender = '';

// Arguments passed to the parser
if ( !empty( $argv['project'] ) ) {
if ( !empty( $argv['project'] ) ) {
$project = $argv['project'];
} elseif ( !empty( $input ) ) {
$project = $input;
Expand Down Expand Up @@ -116,13 +117,17 @@ public static function renderEmbedSnap( $input, $argv, $parser ) {
] );

if ( $hide == 'true' ) {
$elementtorender = Html::openElement( 'details' ) . Html::openElement( 'summary' ) . Html::closeElement( 'summary' ) . $iframe . Html::closeElement( 'details' );
$elementtorender = Html::rawElement(
'details',
[],
Html::element( 'summary' ) . $iframe
);
} elseif ( $hide == 'false' ) {
$elementtorender = $iframe;
}
if ( !empty( $project ) ) {
if ( !empty( $user ) ) {
return (
return (
// If both user and project values are given, it renders the proper iframe.
$elementtorender
);
Expand Down
Loading