Fix SSL deprecation warning in session.py #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `create_ssl_context` method in `_SSLAdapter` class to use `ssl.PROTOCOL_TLS_CLIENT` instead of deprecated options. * Replace `ssl.OP_NO_SSLv2`, `ssl.OP_NO_SSLv3`, and `ssl.OP_NO_TLSv1` with `ssl.PROTOCOL_TLS_CLIENT` in `smartsheet/session.py`. * Add a new test file `tests/integration/test_ssl.py` to verify the absence of deprecation warnings. * Add a test case in `tests/integration/test_ssl.py` to check for deprecation warnings when creating an SSL context. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/sbshah97/smartsheet-python-sdk?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
create_ssl_contextmethod in_SSLAdapterclass to usessl.PROTOCOL_TLS_CLIENTinstead of deprecated options.ssl.OP_NO_SSLv2,ssl.OP_NO_SSLv3, andssl.OP_NO_TLSv1withssl.PROTOCOL_TLS_CLIENTinsmartsheet/session.py.tests/integration/test_ssl.pyto verify the absence of deprecation warnings.tests/integration/test_ssl.pyto check for deprecation warnings when creating an SSL context.