Skip to content

in cover_tree.rs i64::MIN - 1 causes overflow. FIXED. #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mec-iS merged 3 commits into from
Mar 19, 2026
Merged

in cover_tree.rs i64::MIN - 1 causes overflow. FIXED. #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2235c98
in cover_tree.rs i64::MIN - 1 causes overflow. FIXED.
skywardfire1 Mar 19, 2026
08d590e
formatting
skywardfire1 Mar 19, 2026
8ead30c
formatting
skywardfire1 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/algorithm/neighbour/cover_tree.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,10 @@ impl<T: Debug + PartialEq, D: Distance<T>> CoverTree<T, D> {
self.new_leaf(p)
} else {
let max_dist = self.max(point_set);
let next_scale = (max_scale - 1).min(self.get_scale(max_dist));
let next_scale = max_scale // bugfix i64::MIN - 1 causes overflow
.checked_sub(1) // returns None if overflow
.map(|s| s.min(self.get_scale(max_dist)))
.unwrap_or(i64::MIN); // safely getting required value
if next_scale == i64::MIN {
let mut children: Vec<Node> = Vec::new();
let mut leaf = self.new_leaf(p);
Expand Down
2 changes: 0 additions & 2 deletions src/metrics/distance/jaccard.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ mod tests {
all(target_arch = "wasm32", not(target_os = "wasi")),
wasm_bindgen_test::wasm_bindgen_test
)]

#[test]
fn jaccard_distance() {
let a = vec![1, 0, 1, 1];
Expand Down Expand Up @@ -133,4 +132,3 @@ mod tests {
assert!((d1 - d2).abs() < 1e-12);
}
}

Loading