Refactor config for CCT Foundry #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to the foundry scripting utilities and documentation for cross-chain token and pool management. The most significant changes are the removal of the
HelperUtilsdependency in favor of using methods directly fromHelperConfig, the addition of Optimism Sepolia network support, and updates to naming conventions and documentation for consistency and clarity.Key changes:
Helper utilities refactor and simplification:
HelperUtilsimport and updated all scripts to use the newgetNetworkConfigandgetChainmethods directly fromHelperConfig, simplifying code and reducing indirection. (ccip/cct/foundry/script/AddRemotePool.s.sol,ccip/cct/foundry/script/RemoveRemotePool.s.sol,ccip/cct/foundry/script/GetCurrentRateLimits.s.sol,ccip/cct/foundry/script/AcceptAdminRole.s.sol,ccip/cct/foundry/script/ApplyChainUpdates.s.sol,ccip/cct/foundry/script/ClaimAdmin.s.sol,ccip/cct/foundry/script/DeployBurnMintTokenPool.s.sol,ccip/cct/foundry/script/DeployLockReleaseTokenPool.s.sol,ccip/cct/foundry/script/DeployToken.s.sol,ccip/cct/foundry/script/MintTokens.s.sol— [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Network configuration enhancements:
HelperConfig, including a new configuration function and handling for the associated chain ID. Also added a generalgetNetworkConfigfunction to retrieve network configurations by chain ID. (ccip/cct/foundry/script/HelperConfig.s.sol— [1] [2] [3]Documentation and naming consistency:
README.mdand script output paths to use the new chain alias naming convention (e.g.,avalanche_fujiinstead ofavalancheFuji,arbitrum_one_sepoliainstead ofarbitrumSepolia). This ensures consistency between code, configuration, and documentation. (ccip/cct/foundry/README.md— [1] [2] [3] [4] [5] [6] [7] [8]These changes improve maintainability, clarity, and extensibility of the foundry scripting environment for cross-chain token operations.