Conversation
|
product-security-plaid-production
Bot
requested a review
from DimitriosNaikopoulos
| aws-region: ${{ secrets.AWS_REGION }} | ||
| aws-role-arn: ${{ secrets.AWS_OIDC_MCMS_CI_CHANGESET_TOKEN_ISSUER_ROLE_ARN }} | ||
| aws-lambda-url: ${{ secrets.GATI_LAMBDA_DEPLOYMENT_AUTOMATION_URL }} | ||
| # cd-release: |
There was a problem hiding this comment.
Just leaving these commented out for now while we test the new release process
jkongie
force-pushed
the
release-please-implementation
branch
2 times, most recently
from
f13d105 to
88560e0
Compare
There was a problem hiding this comment.
Pull request overview
Migrates the repository’s release automation from Changesets to Release Please by adding Release Please configuration/workflows and updating contributor/release documentation accordingly.
Changes:
- Add Release Please workflow plus
release-please-config.jsonand.release-please-manifest.json. - Update
RELEASE.md/CONTRIBUTING.mdguidance to rely on Conventional Commit PR titles instead of Changesets. - Disable (via comments) existing Changesets-driven and tag-driven release publishing steps in GitHub workflows.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
RELEASE.md |
Rewrites release documentation to describe Release Please + Conventional Commits. |
CONTRIBUTING.md |
Removes Changesets contribution steps and updates PR title guidance/team reference. |
release-please-config.json |
Adds Release Please configuration (go release type + changelog sections). |
.release-please-manifest.json |
Introduces Release Please manifest with the “current” version. |
.github/workflows/release-please.yml |
Adds workflow to open/maintain Release Please PRs and create releases/tags on merge. |
.github/workflows/push-tag-release.yml |
Comments out prior publish + Slack notification jobs for tag pushes. |
.github/workflows/push-main.yml |
Comments out the old Changesets CD job; adjusts Solana cache key formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| ".": "0.42.1" | |||
| key: "${{ | ||
| runner.os}}-mcms-contracts-${{steps.solana-programs-cache-key.outputs.key }}" |
| ## Release Please | ||
|
|
||
| After every PR with a changeset is merged, a changesets CI job will create or update a "Version Packages" PR, which contains the release version and information about the changes. | ||
| This repo uses [Release Please](https://github.com/googleapis/release-please) to manage releases. Do not run `pnpm changeset` or add changeset files for releases. |
| # cicd-publish-release: | ||
| # runs-on: ubuntu-latest | ||
| # permissions: | ||
| # id-token: write | ||
| # contents: write | ||
| # actions: read | ||
| # steps: | ||
| # - name: cicd-publish-release | ||
| # uses: smartcontractkit/.github/actions/cicd-build-publish-artifacts-go@b4737861584f88fa9569d6978f70fedf8b1ae67c # cicd-build-publish-artifacts-go@0.4.0 | ||
| # with: |
| # cd-release: | ||
| # runs-on: ubuntu-latest | ||
| # permissions: | ||
| # id-token: write | ||
| # contents: read | ||
| # steps: | ||
| # - name: cd-release | ||
| # uses: smartcontractkit/.github/actions/cicd-changesets@01d931b0455a754d12e7143cc54a5a3521a8f6f6 # cicd-changesets@0.3.6 |
jkongie
force-pushed
the
release-please-implementation
branch
from
88560e0 to
6f9c7a2
Compare
|
No description provided.