enable full row clickability#3745
Open
gfletcher-cll wants to merge 2 commits intomainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
👋 gfletcher-cll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
ChainTablecomponent and its styles to improve table row interaction, accessibility, and layout consistency. The main changes include making table rows clickable (instead of just the chain name), extracting lane-opening logic for reuse, and updating CSS for better alignment, minimum widths, and responsive behavior.Component logic and accessibility improvements:
ChainTableso that each table row is now clickable, accessible via keyboard (Enter key), and uses a newopenLanefunction to display lane details in a drawer. This replaces the previous button-based approach for improved usability and accessibility. [1] [2]onKeyDownevents and settingtabIndex=0.Table and filter layout enhancements:
min-width: 700px) on the table to prevent column collapse when the search input expands.Style and code cleanup:
These changes collectively make the table more interactive, accessible, and visually consistent across screen sizes.