Keep WASM debug symbols for simulate command #305
Merged
Conversation
|
👋 ejacquier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
timothyF95
reviewed
Mar 10, 2026
cmd/workflow/simulate/simulate.go
Outdated
| spinner := ui.NewSpinner() | ||
| spinner.Start("Compiling workflow...") | ||
| wasmFileBinary, err := cmdcommon.CompileWorkflowToWasm(resolvedWorkflowPath) | ||
| wasmFileBinary, err := cmdcommon.CompileWorkflowToWasm(resolvedWorkflowPath, false) |
Contributor
There was a problem hiding this comment.
Worth noting: with debug symbols kept for simulate but stripped for deploy, the simulate binary will be larger than the deploy binary. This means it's possible (though unlikely in practice) to hit the decompressed binary size limit locally during simulate, while the stripped binary would deploy fine. Simulate is supposed to be the "try before you deploy" step, so a false negative there could be confusing.
timothyF95
previously approved these changes
Mar 10, 2026
timothyF95
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary