chore: port zkevm funcs#51
Merged
ajaskolski merged 2 commits intomainfrom May 8, 2026
Merged
Conversation
ChrisAmora
approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Ports zkSync VM deployment helpers for MCMS-related contracts into the legacy EVM changesets, and updates the chainlink-ccip/chains/solana dependency pin.
Changes:
- Added generated zkSync deployment wrappers for
ManyChainMultiSig,RBACTimelock, andCallProxy(CREATE2 via zkSync wallet + wait mined). - Added
DeployMCMSWithConfigEVMhelper with zkSync-aware deployment path and a new unit test file covering config/label behavior and a timelock deploy smoke test. - Updated
github.com/smartcontractkit/chainlink-ccip/chains/solanaand itsgobindingsversion ingo.mod/go.sum.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| legacy/pkg/family/evm/changesets/zksync/RBACTimelockZK.go | Generated zkSync deployment helper and embedded bytecode for RBACTimelock. |
| legacy/pkg/family/evm/changesets/zksync/ManyChainMultiSigZK.go | Generated zkSync deployment helper and embedded bytecode for ManyChainMultiSig. |
| legacy/pkg/family/evm/changesets/zksync/CallProxyZK.go | Generated zkSync deployment helper and embedded bytecode for CallProxy. |
| legacy/pkg/family/evm/changesets/deploy_mcms.go | Adds a legacy helper to deploy MCMS and apply config, with zkSync deployment support. |
| legacy/pkg/family/evm/changesets/deploy_mcms_test.go | Adds tests for MCMS deploy-with-config (incl. labels) and timelock deploy flow. |
| go.mod | Pins Solana CCIP deps to a different commit. |
| go.sum | Updates checksums to match the new Solana CCIP dependency versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| mcmsTx, err := mcm.Contract.SetConfig(chain.DeployerKey, | ||
| signerAddresses, | ||
| // Signer 1 is int group 0 (root group) with quorum 1. |
Comment on lines
+45
to
+60
| require.NoError(t, err) | ||
| require.Empty(t, mcmNoLabel.Tv.Labels, "expected no label to be set") | ||
|
|
||
| // 2) Test WITH a label | ||
| label := "SA" | ||
| mcmWithLabel, err := DeployMCMSWithConfigEVM( | ||
| mcmscontracts.ProposerManyChainMultisig, | ||
| lggr, | ||
| chain, | ||
| ab, | ||
| cldftesthelpers.SingleGroupMCMS(t), | ||
| WithLabel(label), | ||
| ) | ||
| require.NoError(t, err) | ||
| require.NotNil(t, mcmWithLabel.Tv.Labels, "expected labels to be set") | ||
| require.Contains(t, mcmWithLabel.Tv.Labels, label, "label mismatch") |
ajaskolski
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port zkevm mcms bindings and update chainlink-solana commit