Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Solana GenerateView helper on MCMSWithTimelockPrograms to produce an MCMSWithTimelockViewSolana using the MCMS Solana SDK inspectors, plus a Validate method intended to ensure required state is present.
Changes:
- Added
MCMSWithTimelockPrograms.Validate()to sanity-check loaded Solana program/account keys. - Added
MCMSWithTimelockPrograms.GenerateView(ctx, chain)to generate an MCMS+Timelock view using on-chain inspectors. - Introduced new imports (
contextandpkg/contract/mcms/view/v1_0) to support view generation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| timelockInspector := mcmssolanasdk.NewTimelockInspector(chain.Client) | ||
|
|
||
| return v1_0.GenerateMCMSWithTimelockViewSolana(ctx, inspector, timelockInspector, s.McmProgram, | ||
| s.ProposerMcmSeed, s.CancellerMcmSeed, s.BypasserMcmSeed, s.TimelockProgram, s.TimelockSeed) |
Comment on lines
+39
to
+40
| // Validate checks that all fields are non-nil, ensuring it's ready | ||
| // for use generating views or interactions. |
Comment on lines
+44
to
+47
| } | ||
| if s.TimelockProgram.IsZero() { | ||
| return errors.New("timelock program not found") | ||
| } |
Comment on lines
+39
to
+47
| // Validate checks that all fields are non-nil, ensuring it's ready | ||
| // for use generating views or interactions. | ||
| func (s *MCMSWithTimelockPrograms) Validate() error { | ||
| if s.McmProgram.IsZero() { | ||
| return errors.New("mcm program not found") | ||
| } | ||
| if s.TimelockProgram.IsZero() { | ||
| return errors.New("timelock program not found") | ||
| } |
gustavogama-cll
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing
GenerateViewfor solana state loading