Skip to content

feat: add catalog create address refs changeset#38

Draft
gustavogama-cll wants to merge 1 commit intomainfrom
ggama/feat/add-catalog-create-address-refs-changeset
Draft

feat: add catalog create address refs changeset#38
gustavogama-cll wants to merge 1 commit intomainfrom
ggama/feat/add-catalog-create-address-refs-changeset

Conversation

@gustavogama-cll
Copy link
Copy Markdown
Contributor

@gustavogama-cll gustavogama-cll commented May 5, 2026


OPT-2301

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Catalog changeset + operation pair to create AddressRef entries in the Catalog-backed datastore, mirroring the existing “create contract metadata” patterns.

Changes:

  • Introduces CreateAddressRefOp operation to merge the existing datastore into a new in-memory datastore and add provided AddressRef entries.
  • Adds CreateAddressRefChangeset with precondition validation (non-empty input, datastore present, no duplicates, and no existing entries).
  • Adds unit tests covering precondition validation and apply behavior (success + partial failure on duplicate add).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
catalog/operations/create_address_ref.go New operation to add address refs into a merged in-memory datastore and return the updated datastore.
catalog/changesets/create_address_ref.go New changeset that validates input and executes the new operation, returning a ChangesetOutput with datastore + report.
catalog/changesets/create_address_ref_test.go Tests for VerifyPreconditions and Apply, aligned with existing catalog changeset test patterns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gustavogama-cll gustavogama-cll force-pushed the ggama/feat/add-catalog-create-address-refs-changeset branch from 0e5b4a0 to 9dedeb5 Compare May 7, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants