Skip to content

RM bad test case from writeReport, unset gas limit is allowed and def…#22343

Merged
ilija42 merged 1 commit intodevelopfrom
CRE-1914-rm-bad-test-case
May 7, 2026
Merged

RM bad test case from writeReport, unset gas limit is allowed and def…#22343
ilija42 merged 1 commit intodevelopfrom
CRE-1914-rm-bad-test-case

Conversation

@ilija42
Copy link
Copy Markdown
Contributor

@ilija42 ilija42 commented May 7, 2026

…aults to max

Requires

Supports

Copilot AI review requested due to automatic review settings May 7, 2026 17:10
@ilija42 ilija42 requested review from a team as code owners May 7, 2026 17:10
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

👋 ilija42, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

✅ No conflicts with other open PRs targeting develop

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: LOW

This PR updates the CRE EVM v2 regression system tests to remove a WriteReport negative test case that no longer matches the intended behavior (unset/zero gas limit being allowed and defaulting to a maximum).

Changes:

  • Removed the unused expectedWriteReportInvalidGas constant.
  • Removed the WriteReport - invalid gas negative test case for "0" (zero gas), leaving only the clearly-invalid “too low” and “too high” cases.

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 7, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestVRFV2PlusIntegration_ConsumerProxy_HappyPath The test failed during the initialization of calldata, indicating an issue with setting up or accessing the required data or addresses. Logs ↗︎

View Full Report ↗︎Docs

@ilija42 ilija42 requested review from jmank88 and mchain0 May 7, 2026 18:25
@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ilija42 ilija42 added this pull request to the merge queue May 7, 2026
Merged via the queue into develop with commit a35a458 May 7, 2026
123 of 124 checks passed
@ilija42 ilija42 deleted the CRE-1914-rm-bad-test-case branch May 7, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants