Open
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
3279fe7 to
0f5fd2d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW
Improves CI robustness for Local CRE-based workflows by adding retry logic around environment startup (and observability stack startup where required), mitigating transient container pull/auth failures (e.g., ECR “unauthorized”).
Changes:
- Introduces a reusable composite action to start the Local CRE environment with retries and cleanup between attempts.
- Updates CRE system/regression workflows to use the composite action and configure retry parameters.
- Adds retry logic for starting the observability stack in workflows that depend on it.
Scrupulous human review recommended (targeted areas):
.github/actions/start-local-cre-environment/action.yml: confirmenv stopis the correct teardown between retries for partially-started environments and won’t mask useful intermediate failure signals..github/workflows/cre-system-tests.yaml: confirm the observability retry/validation logic matches expected service names/ports and failure modes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/cre-system-tests.yaml |
Adds retry logic for observability startup (Beholder suite) and switches Local CRE startup to the new composite action with retries. |
.github/workflows/cre-soak-memory-leak.yml |
Adds retry logic for observability startup and switches Local CRE startup to the new composite action. |
.github/workflows/cre-regression-system-tests.yaml |
Switches Local CRE startup to the new composite action with retries. |
.github/actions/start-local-cre-environment/action.yml |
New composite action implementing retried go run . env start with env stop between failed attempts. |
| set -u | ||
| attempt=1 | ||
| while [[ "$attempt" -le "$OBS_MAX_ATTEMPTS" ]]; do | ||
| echo "::startgroup::Starting observability stack (attempt ${attempt}/${OBS_MAX_ATTEMPTS}, required by leak package)" |
| while [[ "$attempt" -le "$OBS_MAX_ATTEMPTS" ]]; do | ||
| echo "::group::Starting Observability Stack (attempt ${attempt}/${OBS_MAX_ATTEMPTS})" | ||
| echo "Test requires observability stack for '${TEST_NAME}', starting..." | ||
| go run . obs up -f |
|
jmank88
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





it should help us to avoid issues like this:
Verification:
Source: https://github.com/smartcontractkit/chainlink/actions/runs/25506786634/job/74855632140