fix(ccip): LoadChainState handles EVM2EVMOnRamp/EVM2EVMOffRamp v1.5 address-book entries#22339
Draft
joaoluisam wants to merge 3 commits intodevelopfrom
Draft
fix(ccip): LoadChainState handles EVM2EVMOnRamp/EVM2EVMOffRamp v1.5 address-book entries#22339joaoluisam wants to merge 3 commits intodevelopfrom
joaoluisam wants to merge 3 commits intodevelopfrom
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for recognizing and loading legacy v1.5 EVM2EVMOnRamp and EVM2EVMOffRamp contract types in the chain state loader, ensuring backward compatibility for migrations and legacy deployments. It also introduces a comprehensive test to verify the correct handling of these legacy contract keys and their mapping to the appropriate contract ABIs.
Legacy contract support and test coverage:
LoadChainStateinstate.goto recognize both legacy and standard type/version keys for EVM2EVMOnRamp and EVM2EVMOffRamp contracts, allowing them to be loaded when theloadLegacyContractsflag is set. [1] [2]EVM2EVMOnRampandEVM2EVMOffRamptotypes.gofor legacy v1.5 datastore aliases, matching on-chain typeAndVersion values.Testing enhancements:
TestLoadChainState_LegacyV15EVM2EVMDatastoreKeysinstate_test.goto deploy v1.5 onramp/offramp contracts, verify their loading behavior with and without the legacy flag, and check correct ABI assignments.state_test.goto support the new tests.