[DX-3716] Fixes Flaky VRFv2 Tests + CI Core Timeouts#22324
Open
[DX-3716] Fixes Flaky VRFv2 Tests + CI Core Timeouts#22324
Conversation
product-security-plaid-production
Bot
requested review from
MStreet3 and
tarcisiozf
Contributor
|
👋 kalverra, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
|
mchain0
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results of using the chainlink-test-diagnosis skill on the
core/services/vrf/v2/package.I primarily used
claudewithsonnet-4.6 | high effort. It took 2 sessions, totaling ~1 hour (not includingdiagnoseruntime) and~500ktotal tokens, costing approximately$7.50.Initial Findings
go -C ./tools/test run . diagnose --iterations 100 --parallel-iterations 5 -- --timeout 10m ./core/services/vrf/v2/...20% Flake Rate
Flaky Tests Identified & Fixed
Verified these tests did not flake again after running with
200iterations. Also, no more instances of the nasty CI Core timeouts I discovered earlier.What Was the Fix?
Filterfunctions for exploring on-chain events. TheFilterfunction is async and can hit odd race conditions when used improperly (as many of the tests did). We either used more deterministic methods of examining on-chain events (transaction receipts) or implemented retry loops.Why Don't We Have Flaky Test Tickets for All of These?