chore: swap aptos state loading funcs with cld-changesets#22312
Draft
chore: swap aptos state loading funcs with cld-changesets#22312
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes aptos state loading files and usages swapping it with cld-changesets.
AI Summary
This pull request refactors how MCMS addresses for Aptos chains are loaded by removing the local implementation and switching to a shared utility. The main goal is to reduce code duplication and centralize the logic for fetching MCMS addresses for Aptos, improving maintainability.
Key changes:
Refactoring and Code Reuse
LoadMCMSAddressesAptosfromdeployment/common/changeset/state/aptos.go, deleting the entire file.set_config_mcms.goto useaptosstate.LoadMCMSAddressesfrom the sharedcld-changesetspackage instead of the deleted local version.Usage Updates
LoadMCMSAddressesAptosfunction inset_config_mcms.gowith the new shared function, ensuring all MCMS address loading for Aptos now uses the centralized implementation. [1] [2]