Open
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
product-security-plaid-production
bot
requested review from
chainchad and
kalverra
Contributor
There was a problem hiding this comment.
Pull request overview
Risk rating: MEDIUM (changes a required CI check’s failure/retry behavior and could impact merge gating)
This PR refactors the SigScanner GitHub Actions workflow to make the request payload construction clearer and to add retry behavior for SigScanner 5xx responses.
Changes:
- Adds explicit
permissions: {}to the workflow and cleans up the workflow header. - Refactors the SigScanner POST request to build JSON via
jq. - Introduces retry logic (with backoff) for 5xx HTTP responses from SigScanner.
jmank88
previously approved these changes
Mar 19, 2026
erikburt
force-pushed
the
feat/sigscanner-retries
branch
from
e3d6b22 to
78686a9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
erikburt
force-pushed
the
feat/sigscanner-retries
branch
from
78686a9 to
0d39f53
Compare
jmank88
previously approved these changes
Mar 19, 2026
|
erikburt
force-pushed
the
feat/sigscanner-retries
branch
from
0d39f53 to
af6d0d8
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up signscanner workflow, and adds retries for 5xx errors.
Testing
happy case works:
5xx case, wont be any worse than it is now.