[NONEVM-2994] [OnRamp] Validate sender is SenderExecutor on commit #328
Conversation
|
👋 patricios-space, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull Request Overview
This PR implements sender validation in the OnRamp contract by verifying that the sender is the authorized send executor for a given message ID. The changes replace a TODO comment with actual validation logic and refactor the executor address generation into a reusable inline function.
Key Changes:
- Added sender validation in
commitandreplyWithErrorfunctions to ensure only authorized executors can call these functions - Extracted executor address calculation into a reusable
executorAddresssinline function - Imported error definitions from the offramp module
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
patricios-space
force-pushed
the
fix/send-executor-validation
branch
from
713431e to
8b0684e
Compare
patricios-space
requested review from
archseer,
krebernisak and
vicentevieytes
patricios-space
force-pushed
the
fix/send-executor-validation
branch
from
dc19874 to
92e7f47
Compare
| }) | ||
| } | ||
| }) | ||
|
|
There was a problem hiding this comment.
I will refactor this test to fit inside the e2e below in a later PR: #332
patricios-space
force-pushed
the
fix/send-executor-validation
branch
from
92e7f47 to
aaddd51
Compare
patricios-space
changed the title
2 participants
No description provided.