-
Notifications
You must be signed in to change notification settings - Fork 4
github workflow: add evm chain #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
👋 wilson-cl, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to "scope" these workflows to the CRE team.
Could you please:
- change the filenames to
cre-add-evm-chain.ymlandcre-notify-sdk-go.yml - update CODEOWNERS so that the cre team owns
.github/workflows/cre-*.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- renamed with cre-prefix
- updated codeowners with .github/workflows/cre-*.yml
This pull request introduces automation for adding new EVM chains to the
client.protofile, both by providing a new GitHub Actions workflow and by adding a supporting CLI tool. The workflow allows chains to be added via manual, API, or workflow triggers, while the CLI tool handles the logic of updating the proto file with the new chain information.Automation for adding EVM chains:
.github/workflows/add-evm-chain.yml) that automates the process of adding an EVM chain toclient.proto, regenerates embedded files, and creates a pull request. The workflow can be triggered manually, programmatically, or via API, and outputs a summary with chain and PR details.Supporting CLI tool for proto updates:
cre/go/tools/add-evm-chain/main.go) that takes a chain selector, looks up the corresponding chain name using thechain-selectorslibrary, checks for duplicates, inserts the new entry in sorted order into thedefaultsarray inclient.proto, and writes the updated file.Example Flow