Open
Conversation
Contributor
📊 API Diff Results
|
vlfig
force-pushed
the
harmonize-rpcclient-metrics
branch
from
3f25414 to
5677022
Compare
pass the rpc domain to RPCClientBase, not the url bump cl-framework (brings better labels and sanitization)
vlfig
force-pushed
the
harmonize-rpcclient-metrics
branch
from
5677022 to
03fac52
Compare
product-security-plaid-production
Bot
requested review from
RayXpub,
dhaidashenko,
jmank88 and
russell-stern
Contributor
There was a problem hiding this comment.
Pull request overview
This PR harmonizes RPC client metrics by passing an RPC “domain” identifier (host) into multinode.RPCClientBase instead of a full URL, and bumps chainlink-framework/metrics to pick up improved labeling and sanitization.
Changes:
- Update
NewRPCClientto passr.getRPCDomain()intomultinode.NewRPCClientBaserather than a full RPC URL string. - Bump
github.com/smartcontractkit/chainlink-framework/metricstov0.0.0-20260508154216-3ed6f623098f. - Update
go.sumaccordingly.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/client/rpc_client.go | Passes RPC domain (host) into RPCClientBase for metrics consistency. |
| go.mod | Bumps chainlink-framework/metrics dependency version. |
| go.sum | Updates checksums for the bumped metrics dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| rpcBaseMetrics = r.beholderMetrics.rpcClientMetrics | ||
| } | ||
| r.RPCClientBase = multinode.NewRPCClientBase[*evmtypes.Head](cfg, QueryTimeout, lggr, r.latestBlock, r.latestFinalizedBlock, rpcURL, isSendOnly, rpcBaseMetrics) | ||
| r.RPCClientBase = multinode.NewRPCClientBase[*evmtypes.Head](cfg, QueryTimeout, lggr, r.latestBlock, r.latestFinalizedBlock, r.getRPCDomain(), isSendOnly, rpcBaseMetrics) |
Contributor
Author
There was a problem hiding this comment.
The theoretical panic risk is already there and it's not happening in reality because we're always called with at least one of wsuri or httpuri non-nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the rpc domain to RPCClientBase, not the url, for consistency.
Bump
chainlink-framework/metrics. Brings better labels and sanitization (smartcontractkit/chainlink-framework#106)