DF-23975: Updates LimitDefault gas estimator values for Arsia Upgrade#442
Conversation
|
👋 cl-efornaciari, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
Updates Mantle chain default TOML configurations to reflect new gas estimator LimitDefault values for the Arsia upgrade.
Changes:
- Lowered
GasEstimator.LimitDefaultfor Mantle Mainnet and Mantle Sepolia to50_000_000. - Removed the Mantle-specific
GasEstimator.LimitMaxoverride in both configs (now inherited fromfallback.toml).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/config/toml/defaults/Mantle_Sepolia.toml | Adjusts Mantle Sepolia gas estimator limit defaults for Arsia upgrade. |
| pkg/config/toml/defaults/Mantle_Mainnet.toml | Adjusts Mantle Mainnet gas estimator limit defaults for Arsia upgrade. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Limit values are high as Mantle's GasPrice is in native token (MNT) instead of ETH. Their proprietary TokenRatio parameter is used to adjust fees | ||
| LimitDefault = 80_000_000_000 | ||
| LimitMax = 100_000_000_000 | ||
| LimitDefault = 50_000_000 | ||
| BumpMin = '100 wei' |
There was a problem hiding this comment.
This hunk changes more than the PR title suggests: it also removes the Mantle-specific LimitMax override (now it will fall back to fallback.toml’s LimitMax = 500_000). Please confirm this is intentional; if so, consider updating the PR title/description to mention the LimitMax behavior change, or keep an explicit LimitMax here to avoid surprising future maintainers.
| # Limit values are high as Mantle's GasPrice is in native token (MNT) instead of ETH. Their proprietary TokenRatio parameter is used to adjust fees | ||
| LimitDefault = 80000000000 | ||
| LimitMax = 100000000000 | ||
| LimitDefault = 50_000_000 | ||
| BumpMin = '100 wei' |
There was a problem hiding this comment.
This hunk changes more than the PR title suggests: it also removes the Mantle-specific LimitMax override (now it will fall back to fallback.toml’s LimitMax = 500_000). Please confirm this is intentional; if so, consider updating the PR title/description to mention the LimitMax behavior change, or keep an explicit LimitMax here to avoid surprising future maintainers.
There was a problem hiding this comment.
Intentional. LimitMax was changed erroneously in a previous PR by me. Has no effect on Mantle.
| @@ -13,8 +13,7 @@ HistoryDepth = 1250 | |||
| [GasEstimator] | |||
| PriceMax = '120 gwei' | |||
| # Limit values are high as Mantle's GasPrice is in native token (MNT) instead of ETH. Their proprietary TokenRatio parameter is used to adjust fees | |||
There was a problem hiding this comment.
The comment about “Limit values are high … GasPrice … TokenRatio … adjust fees” reads like it is describing gas price behavior, but it’s attached to gas limit settings and (after this change) only LimitDefault is set here. Consider rewording this comment to clarify why LimitDefault needs to be elevated on Mantle, or move this rationale next to the relevant fee fields if it’s actually about pricing.
| # Limit values are high as Mantle's GasPrice is in native token (MNT) instead of ETH. Their proprietary TokenRatio parameter is used to adjust fees | |
| # Mantle transactions can require a higher gas limit than our usual defaults, so keep | |
| # the default transaction gas limit elevated for this network. |
| @@ -13,8 +13,7 @@ HistoryDepth = 1250 | |||
| [GasEstimator] | |||
| PriceMax = '120 gwei' | |||
| # Limit values are high as Mantle's GasPrice is in native token (MNT) instead of ETH. Their proprietary TokenRatio parameter is used to adjust fees | |||
There was a problem hiding this comment.
The comment about “Limit values are high … GasPrice … TokenRatio … adjust fees” reads like it is describing gas price behavior, but it’s attached to gas limit settings and (after this change) only LimitDefault is set here. Consider rewording this comment to clarify why LimitDefault needs to be elevated on Mantle, or move this rationale next to the relevant fee fields if it’s actually about pricing.
| # Limit values are high as Mantle's GasPrice is in native token (MNT) instead of ETH. Their proprietary TokenRatio parameter is used to adjust fees | |
| # Mantle uses a higher default gas limit here, so keep LimitDefault elevated for transactions on this chain. |
No description provided.