PLEX-2794 N-09 fix inconsistent head snapshots#438
Open
dhaidashenko wants to merge 1 commit intofix/PLEX-2793-N-08-ensure-heads-not-nilfrom
Open
PLEX-2794 N-09 fix inconsistent head snapshots#438dhaidashenko wants to merge 1 commit intofix/PLEX-2793-N-08-ensure-heads-not-nilfrom
dhaidashenko wants to merge 1 commit intofix/PLEX-2793-N-08-ensure-heads-not-nilfrom
Conversation
Contributor
✅ API Diff Results - No breaking changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pollAndSaveLogs function derives on-chain status from latestBlocks and latestSafeBlock, but those helpers only clamp zero values and never verify the basic ordering finalized <= safe <= latest before the numbers are used and persisted. The resulting latestFinalizedBlockNumber drives the finalized backfill bound lastSafeBackfillBlock := latestFinalizedBlockNumber - 1, and the finalized / safe values are written into block checkpoints during getUnfinalizedLogs. If the poller observes a self-inconsistent head tuple, it can make poor control-flow decisions such as attempting out-of-range backfills or persisting inflated confirmation metadata that later feeds confirmed-read cutoffs through withConfs.
Fix
Use blocks with higher confidence if their block number is higher to guarantee latest >= safe >= finalized.