PLEX-2783 N-08 LP: ensure heads not nil before dereferencing#437
Open
dhaidashenko wants to merge 1 commit intofix/PLEX-2791-N-06-improve-lp-health-observabilityfrom
Open
Conversation
Contributor
✅ API Diff Results - No breaking changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nil Head Returns Can Panic LogPoller Polling and Replay Paths
The latestBlocks, latestSafeBlock, and Replay functions dereference *Head values without checking for nil on success, which can result in a panic on the log poll or replay attempt instead of a controlled failure.
Fix
Both HeadTracker and RPC client implementation guarantee that the returned Head won't be nil. However, we should not trust the implementation details, so it's better to add safeguards to avoid panic.